Clean up some lint complaints and fix center_of_mass()

Clean up some lint complaints and fix center_of_mass()

Fix some variable shadowing warnings found by /analyze.
The variable shadowing fix in center_of_mass changes the
behavior of center_of_mass, presumably to reflect the
intent of the function.

BUG=skia:4287
Committed: https://skia.googlesource.com/skia/+/44c3128bd892d32f797810d93ef1ed392e0b902d

[robertphillips, 2015-09-03 17:53:19]

robertphillips@google.com changed reviewers:
+ ethannicholas@google.com, jvanverth@google.com

[jvanverth1, 2015-09-03 18:11:20]

lgtm

[robertphillips, 2015-09-03 19:50:00]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-03 19:50:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1327943003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1327943003/1

[commit-bot: I haz the power, 2015-09-03 19:55:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-03 19:55:10]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-09-03 19:57:39]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-09-03 19:57:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1327943003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1327943003/1

[commit-bot: I haz the power, 2015-09-03 19:58:51]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/44c3128bd892d32f797810d93ef1ed392e0b902d

[brucedawson, 2015-09-03 20:03:49]

brucedawson@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brucedawson, 2015-09-03 20:03:50]

It's too late now, but I worry that the description of this change is
inaccurate. Most of the changes are indeed just to make lint/analyze shut up,
but fixing the pj variable shadowing in center_of_mass is actually a behavior
changing fix.

[mtklein, 2015-09-03 20:07:54]

On 2015/09/03 20:03:50, brucedawson wrote:
> It's too late now, but I worry that the description of this change is
> inaccurate. Most of the changes are indeed just to make lint/analyze shut up,
> but fixing the pj variable shadowing in center_of_mass is actually a behavior
> changing fix.

It's not really too late.  If we're really worried, can't we still just change
CL description?

[brucedawson, 2015-09-03 20:08:38]

Good point. The git commit won't show it but the CL will.

[mikerreed, 2015-09-03 23:25:41]

mike@reedtribe.org changed reviewers:
+ mike@reedtribe.org

[mikerreed, 2015-09-03 23:25:41]

Did this CL break these LayoutTests?

http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/7...

There are some circle-related GPU runs.

We may need to suppress or revert to let the roll through...

[brucedawson, 2015-09-04 17:28:16]

That's certainly possible. It may be that the new center_of_mass() behavior is
actually wrong, or it may be that the tests depend on the previous behavior even
though it was wrong.