Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1327763002: Cleanup: Remove some LOG(ERROR) in ServiceWorkerContextWrapper (Closed)

Created:
5 years, 3 months ago by falken
Modified:
5 years, 3 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove some LOG(ERROR) in ServiceWorkerContextWrapper We haven't found these useful and other code that bails due to no context doesn't log anything. Committed: https://crrev.com/69a8f6885cc7af0e4eec2914ed0bd07f8802b87c Cr-Commit-Position: refs/heads/master@{#346862}

Patch Set 1 #

Total comments: 4

Patch Set 2 : comments #

Patch Set 3 : and rm more .get() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -22 lines) Patch
M content/browser/service_worker/service_worker_context_wrapper.cc View 1 2 10 chunks +9 lines, -22 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
falken
ptal (low priority)
5 years, 3 months ago (2015-09-02 06:10:47 UTC) #2
nhiroki
Thank you for cleaning up! LGTM https://codereview.chromium.org/1327763002/diff/1/content/browser/service_worker/service_worker_context_wrapper.cc File content/browser/service_worker/service_worker_context_wrapper.cc (right): https://codereview.chromium.org/1327763002/diff/1/content/browser/service_worker/service_worker_context_wrapper.cc#newcode197 content/browser/service_worker/service_worker_context_wrapper.cc:197: if (!context_core_.get()) { ...
5 years, 3 months ago (2015-09-02 06:15:38 UTC) #3
nhiroki
nit: s/anthing/anything in CL description
5 years, 3 months ago (2015-09-02 06:16:23 UTC) #4
falken
Thanks, fixed Cl desc https://codereview.chromium.org/1327763002/diff/1/content/browser/service_worker/service_worker_context_wrapper.cc File content/browser/service_worker/service_worker_context_wrapper.cc (right): https://codereview.chromium.org/1327763002/diff/1/content/browser/service_worker/service_worker_context_wrapper.cc#newcode197 content/browser/service_worker/service_worker_context_wrapper.cc:197: if (!context_core_.get()) { On 2015/09/02 ...
5 years, 3 months ago (2015-09-02 06:28:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327763002/40001
5 years, 3 months ago (2015-09-02 06:28:19 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-02 07:27:56 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 07:28:34 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/69a8f6885cc7af0e4eec2914ed0bd07f8802b87c
Cr-Commit-Position: refs/heads/master@{#346862}

Powered by Google App Engine
This is Rietveld 408576698