Cleanup: Remove some LOG(ERROR) in ServiceWorkerContextWrapper

content/browser/service_worker/service_worker_context_wrapper.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_context_wrapper.h"
 
 #include <map>
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 132 matching lines @@
       FROM_HERE,
       base::Bind(&ServiceWorkerContextWrapper::ShutdownOnIO, this));
 }
 
 void ServiceWorkerContextWrapper::DeleteAndStartOver() {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   if (!context_core_) {
     // The context could be null due to system shutdown or restart failure. In
     // either case, we should not have to recover the system, so just return
     // here.
-    LOG(ERROR) << "ServiceWorkerContextCore is no longer alive.";
     return;
   }
   context_core_->DeleteAndStartOver(
       base::Bind(&ServiceWorkerContextWrapper::DidDeleteAndStartOver, this));
 }
 
 StoragePartitionImpl* ServiceWorkerContextWrapper::storage_partition() const {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   return storage_partition_;
 }
@@ skipping 24 matching lines @@
     BrowserThread::PostTask(
         BrowserThread::IO,
         FROM_HERE,
         base::Bind(&ServiceWorkerContextWrapper::RegisterServiceWorker,
                    this,
                    pattern,
                    script_url,
                    continuation));
     return;
   }
   if (!context_core_.get()) {

[nhiroki, 2015/09/02 06:15:38]

nit: How about removing ".get()" like line 149?

[falken, 2015/09/02 06:28:09]

Done.

-    LOG(ERROR) << "ServiceWorkerContextCore is no longer alive.";
     BrowserThread::PostTask(
         BrowserThread::IO,
         FROM_HERE,
         base::Bind(continuation, false));
     return;
   }
   context()->RegisterServiceWorker(
       net::SimplifyUrlForRequest(pattern),
       net::SimplifyUrlForRequest(script_url), NULL /* provider_host */,
       base::Bind(&FinishRegistrationOnIO, continuation));
@@ skipping 16 matching lines @@
     BrowserThread::PostTask(
         BrowserThread::IO,
         FROM_HERE,
         base::Bind(&ServiceWorkerContextWrapper::UnregisterServiceWorker,
                    this,
                    pattern,
                    continuation));
     return;
   }
   if (!context_core_.get()) {
-    LOG(ERROR) << "ServiceWorkerContextCore is no longer alive.";
     BrowserThread::PostTask(
         BrowserThread::IO,
         FROM_HERE,
         base::Bind(continuation, false));
     return;
   }
 
   context()->UnregisterServiceWorker(
       net::SimplifyUrlForRequest(pattern),
       base::Bind(&FinishUnregistrationOnIO, continuation));
 }
 
 void ServiceWorkerContextWrapper::UpdateRegistration(const GURL& pattern) {
   if (!BrowserThread::CurrentlyOn(BrowserThread::IO)) {
     BrowserThread::PostTask(
         BrowserThread::IO, FROM_HERE,
         base::Bind(&ServiceWorkerContextWrapper::UpdateRegistration, this,
                    pattern));
     return;
   }
-  if (!context_core_.get()) {
-    LOG(ERROR) << "ServiceWorkerContextCore is no longer alive.";
+  if (!context_core_.get())
     return;
-  }
   context_core_->storage()->FindRegistrationForPattern(
       net::SimplifyUrlForRequest(pattern),
       base::Bind(&ServiceWorkerContextWrapper::DidFindRegistrationForUpdate,
                  this));
 }
 
 void ServiceWorkerContextWrapper::StartServiceWorker(
     const GURL& pattern,
     const StatusCallback& callback) {
   if (!BrowserThread::CurrentlyOn(BrowserThread::IO)) {
     BrowserThread::PostTask(
         BrowserThread::IO, FROM_HERE,
         base::Bind(&ServiceWorkerContextWrapper::StartServiceWorker, this,
                    pattern, callback));
     return;
   }
   if (!context_core_.get()) {
-    LOG(ERROR) << "ServiceWorkerContextCore is no longer alive.";
     BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
                             base::Bind(callback, SERVICE_WORKER_ERROR_ABORT));
     return;
   }
   context_core_->storage()->FindRegistrationForPattern(
       net::SimplifyUrlForRequest(pattern),
       base::Bind(&StartActiveWorkerOnIO, callback));
 }
 
 void ServiceWorkerContextWrapper::SimulateSkipWaiting(int64_t version_id) {
   if (!BrowserThread::CurrentlyOn(BrowserThread::IO)) {
     BrowserThread::PostTask(
         BrowserThread::IO, FROM_HERE,
         base::Bind(&ServiceWorkerContextWrapper::SimulateSkipWaiting, this,
                    version_id));
     return;
   }
   if (!context_core_.get()) {

[nhiroki, 2015/09/02 06:15:38]

nit: Can you remove {}?

[falken, 2015/09/02 06:28:09]

Done.

-    LOG(ERROR) << "ServiceWorkerContextCore is no longer alive.";
     return;
   }
   ServiceWorkerVersion* version = GetLiveVersion(version_id);
   if (!version || version->skip_waiting())
     return;
   ServiceWorkerRegistration* registration =
       GetLiveRegistration(version->registration_id());
   if (!registration || version != registration->waiting_version())
     return;
   version->set_skip_waiting(true);
@@ skipping 17 matching lines @@
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   context()->storage()->FindRegistrationForDocument(
       net::SimplifyUrlForRequest(url),
       base::Bind(&DidFindRegistrationForDocument, callback));
 }
 
 void ServiceWorkerContextWrapper::GetAllOriginsInfo(
     const GetUsageInfoCallback& callback) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   if (!context_core_.get()) {
-    LOG(ERROR) << "ServiceWorkerContextCore is no longer alive.";
     BrowserThread::PostTask(
         BrowserThread::IO,
         FROM_HERE,
         base::Bind(callback, std::vector<ServiceWorkerUsageInfo>()));
     return;
   }
   context()->storage()->GetAllRegistrationsInfos(base::Bind(
       &ServiceWorkerContextWrapper::DidGetAllRegistrationsForGetAllOrigins,
       this, callback));
 }
@@ skipping 42 matching lines @@
                                    registration->pattern(), other_url)));
 }
 
 void ServiceWorkerContextWrapper::DidFindRegistrationForUpdate(
     ServiceWorkerStatusCode status,
     const scoped_refptr<ServiceWorkerRegistration>& registration) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
 
   if (status != SERVICE_WORKER_OK)
     return;
-  if (!context_core_.get()) {
-    LOG(ERROR) << "ServiceWorkerContextCore is no longer alive.";
+  if (!context_core_.get())
     return;
-  }
   DCHECK(registration);
   context_core_->UpdateServiceWorker(registration.get(),
                                      true /* force_bypass_cache */);
 }
 
 namespace {
 void StatusCodeToBoolCallbackAdapter(
     const ServiceWorkerContext::ResultCallback& callback,
     ServiceWorkerStatusCode code) {
   callback.Run(code == ServiceWorkerStatusCode::SERVICE_WORKER_OK);
 }
 
 void EmptySuccessCallback(bool success) {
 }
 }  // namespace
 
 void ServiceWorkerContextWrapper::DeleteForOrigin(
     const GURL& origin,
     const ResultCallback& result) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   if (!context_core_.get()) {
-    LOG(ERROR) << "ServiceWorkerContextCore is no longer alive.";
     BrowserThread::PostTask(
         BrowserThread::IO,
         FROM_HERE,
         base::Bind(result, false));
     return;
   }
   context()->UnregisterServiceWorkers(
       origin.GetOrigin(), base::Bind(&StatusCodeToBoolCallbackAdapter, result));
 }
 
 void ServiceWorkerContextWrapper::DeleteForOrigin(const GURL& origin) {
   DeleteForOrigin(origin, base::Bind(&EmptySuccessCallback));
 }
 
 void ServiceWorkerContextWrapper::CheckHasServiceWorker(
     const GURL& url,
     const GURL& other_url,
     const CheckHasServiceWorkerCallback& callback) {
   if (!BrowserThread::CurrentlyOn(BrowserThread::IO)) {
     BrowserThread::PostTask(
         BrowserThread::IO, FROM_HERE,
         base::Bind(&ServiceWorkerContextWrapper::CheckHasServiceWorker, this,
                    url, other_url, callback));
     return;
   }
   if (!context_core_.get()) {
-    LOG(ERROR) << "ServiceWorkerContextCore is no longer alive.";
     BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
                             base::Bind(callback, false));
     return;
   }
   context()->storage()->FindRegistrationForDocument(
       net::SimplifyUrlForRequest(url),
       base::Bind(&ServiceWorkerContextWrapper::
                      DidFindRegistrationForCheckHasServiceWorker,
                  this, net::SimplifyUrlForRequest(other_url), callback));
 }
@@ skipping 182 matching lines @@
   observer_list_->Notify(FROM_HERE,
                          &ServiceWorkerContextObserver::OnStorageWiped);
 }
 
 ServiceWorkerContextCore* ServiceWorkerContextWrapper::context() {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   return context_core_.get();
 }
 
 }  // namespace content