Issue 1327753002: [crankshaft] Add baseline implementation of for-of.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1327753002: [crankshaft] Add baseline implementation of for-of. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer

Modified:
5 years ago

Reviewers:
Jarin

CC:
v8-dev, Michael Starzinger, Dan Ehrenberg

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[crankshaft] Add baseline implementation of for-of. This adds a baseline implementation of for-of without any specific optimizations to Crankshaft, and enables compilation of methods containing for-of with Crankshaft. R=jarin@chromium.org

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -2 lines)			Patch
M	src/ast-numbering.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+31 lines, -1 line	0 comments	Download
M	src/typing.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

5 years, 3 months ago (2015-09-02 05:18:57 UTC) #1

Hey Jaro,

Here's the proof-of-concept implementation of for-of in Crankshaft.
This is not intended for landing now. We'll first have to have some
strategic discussion about this.
Please take a look.

Thanks,
Benedikt

Expand Messages | Collapse Messages