Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: src/typing.cc

Issue 1327753002: [crankshaft] Add baseline implementation of for-of. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/hydrogen.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/typing.cc
diff --git a/src/typing.cc b/src/typing.cc
index fb758828b076524a47c6be702050437507d4be95..07e8416e7d232cae12c74332f0d969d0f13f02f0 100644
--- a/src/typing.cc
+++ b/src/typing.cc
@@ -299,7 +299,14 @@ void AstTyper::VisitForInStatement(ForInStatement* stmt) {
void AstTyper::VisitForOfStatement(ForOfStatement* stmt) {
RECURSE(Visit(stmt->iterable()));
+ RECURSE(Visit(stmt->assign_iterator()));
store_.Forget(); // Control may transfer here via looping or 'continue'.
+ RECURSE(Visit(stmt->next_result()));
+ // Collect type feedback.
+ stmt->result_done()->RecordToBooleanTypeFeedback(oracle());
+ ObserveTypesAtOsrEntry(stmt);
+ RECURSE(Visit(stmt->result_done()));
+ RECURSE(Visit(stmt->assign_each()));
RECURSE(Visit(stmt->body()));
store_.Forget(); // Control may transfer here via 'break'.
}
« no previous file with comments | « src/hydrogen.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698