content/browser/renderer_host/render_widget_host_view_mac_unittest.mm - Issue 1327743002: Avoid sync IPCs for firstRectForCharacterRange/attributedSubstringForProposedRange.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

Issue 1327743002: Avoid sync IPCs for firstRectForCharacterRange/attributedSubstringForProposedRange. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed bugs in original cl 1301173002. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm b/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

index d582cab7c099690d7f5a6e015ce4601ef9eba941..16b8d5037e6f20a20289f3fb96b4e3dee3badbe4 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

@@ -400,15 +400,15 @@ TEST_F(RenderWidgetHostViewMacTest, GetFirstRectForCharacterRangeCaretCase) {

gfx::Range(0, 1).ToNSRange(),

&rect,

&actual_range));

- EXPECT_FALSE(rwhv_mac_->GetCachedFirstRectForCharacterRange(

+ EXPECT_TRUE(rwhv_mac_->GetCachedFirstRectForCharacterRange(

gfx::Range(1, 1).ToNSRange(),

&rect,

&actual_range));

- EXPECT_FALSE(rwhv_mac_->GetCachedFirstRectForCharacterRange(

+ EXPECT_TRUE(rwhv_mac_->GetCachedFirstRectForCharacterRange(

gfx::Range(1, 2).ToNSRange(),

&rect,

&actual_range));

- EXPECT_FALSE(rwhv_mac_->GetCachedFirstRectForCharacterRange(

+ EXPECT_TRUE(rwhv_mac_->GetCachedFirstRectForCharacterRange(

gfx::Range(2, 2).ToNSRange(),

&rect,

&actual_range));

« content/browser/renderer_host/render_widget_host_view_mac.mm ('K') | « content/browser/renderer_host/render_widget_host_view_mac.mm ('k') | no next file » | no next file with comments »