Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1327743002: Avoid sync IPCs for firstRectForCharacterRange/attributedSubstringForProposedRange. (Closed)

Created:
5 years, 3 months ago by Shu Chen
Modified:
5 years, 1 month ago
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid sync IPCs for firstRectForCharacterRange/attributedSubstringForProposedRange. This reverts commit 64883bfcc6088e2cc7b447aa419d972d8346884f. For firstRectForCharacterRange, always uses the cached rect. And it will make IME get the wrong/old rect to position its suggestion window. For attributedSubstringForProposedRange, always uses composition or selection text. And it will drop the string format (fonts/color/etc.) information. This cl is a trade-off between making IME behave properly and avoid freezing UI. BUG=121917, 473850 TEST=Verified bug not repro on local build. Committed: https://crrev.com/7e0fac6e1d8c79e7658a94e96a3f0246dc541d82 Cr-Commit-Position: refs/heads/master@{#350170}

Patch Set 1 #

Patch Set 2 : fixed bugs in original cl 1301173002. #

Total comments: 6

Patch Set 3 : addressed some of palmer's comments. #

Total comments: 7

Patch Set 4 : #

Total comments: 2

Patch Set 5 : addressed palmer@'s comment.s #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -9 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.h View 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 4 4 chunks +48 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (3 generated)
Shu Chen
https://codereview.chromium.org/1327743002/diff/20001/content/browser/renderer_host/render_widget_host_view_mac.mm File content/browser/renderer_host/render_widget_host_view_mac.mm (right): https://codereview.chromium.org/1327743002/diff/20001/content/browser/renderer_host/render_widget_host_view_mac.mm#newcode2923 content/browser/renderer_host/render_widget_host_view_mac.mm:2923: expected_range = gfx::Range(offset, offset + expected_text->size()); from palmer@: How ...
5 years, 3 months ago (2015-09-02 05:04:36 UTC) #2
Shu Chen
https://codereview.chromium.org/1327743002/diff/20001/content/browser/renderer_host/render_widget_host_view_mac.mm File content/browser/renderer_host/render_widget_host_view_mac.mm (right): https://codereview.chromium.org/1327743002/diff/20001/content/browser/renderer_host/render_widget_host_view_mac.mm#newcode2923 content/browser/renderer_host/render_widget_host_view_mac.mm:2923: expected_range = gfx::Range(offset, offset + expected_text->size()); On 2015/09/02 05:04:36, ...
5 years, 3 months ago (2015-09-02 05:41:22 UTC) #3
Shu Chen
Kindly pinging for reviews.
5 years, 3 months ago (2015-09-02 05:44:16 UTC) #4
palmer
https://codereview.chromium.org/1327743002/diff/40001/content/browser/renderer_host/render_widget_host_view_mac.mm File content/browser/renderer_host/render_widget_host_view_mac.mm (right): https://codereview.chromium.org/1327743002/diff/40001/content/browser/renderer_host/render_widget_host_view_mac.mm#newcode2933 content/browser/renderer_host/render_widget_host_view_mac.mm:2933: &(*expected_text)[requested_range.start() - expected_range.start()]; I still don't understand this. https://codereview.chromium.org/1327743002/diff/40001/content/browser/renderer_host/render_widget_host_view_mac.mm#newcode2935 ...
5 years, 3 months ago (2015-09-02 20:17:22 UTC) #5
Shu Chen
https://codereview.chromium.org/1327743002/diff/40001/content/browser/renderer_host/render_widget_host_view_mac.mm File content/browser/renderer_host/render_widget_host_view_mac.mm (right): https://codereview.chromium.org/1327743002/diff/40001/content/browser/renderer_host/render_widget_host_view_mac.mm#newcode2933 content/browser/renderer_host/render_widget_host_view_mac.mm:2933: &(*expected_text)[requested_range.start() - expected_range.start()]; On 2015/09/02 20:17:22, palmer wrote: > ...
5 years, 3 months ago (2015-09-03 15:07:32 UTC) #6
Alexei Svitkine (slow)
lgtm
5 years, 3 months ago (2015-09-03 16:28:53 UTC) #7
palmer
https://codereview.chromium.org/1327743002/diff/40001/content/browser/renderer_host/render_widget_host_view_mac.mm File content/browser/renderer_host/render_widget_host_view_mac.mm (right): https://codereview.chromium.org/1327743002/diff/40001/content/browser/renderer_host/render_widget_host_view_mac.mm#newcode2933 content/browser/renderer_host/render_widget_host_view_mac.mm:2933: &(*expected_text)[requested_range.start() - expected_range.start()]; > For example, expected_text == "hello ...
5 years, 3 months ago (2015-09-03 23:03:59 UTC) #8
Shu Chen
https://codereview.chromium.org/1327743002/diff/40001/content/browser/renderer_host/render_widget_host_view_mac.mm File content/browser/renderer_host/render_widget_host_view_mac.mm (right): https://codereview.chromium.org/1327743002/diff/40001/content/browser/renderer_host/render_widget_host_view_mac.mm#newcode2933 content/browser/renderer_host/render_widget_host_view_mac.mm:2933: &(*expected_text)[requested_range.start() - expected_range.start()]; On 2015/09/03 23:03:59, palmer wrote: > ...
5 years, 3 months ago (2015-09-04 01:36:47 UTC) #9
palmer
https://codereview.chromium.org/1327743002/diff/40001/content/browser/renderer_host/render_widget_host_view_mac.mm File content/browser/renderer_host/render_widget_host_view_mac.mm (right): https://codereview.chromium.org/1327743002/diff/40001/content/browser/renderer_host/render_widget_host_view_mac.mm#newcode2933 content/browser/renderer_host/render_widget_host_view_mac.mm:2933: &(*expected_text)[requested_range.start() - expected_range.start()]; > > So, it sounds like ...
5 years, 3 months ago (2015-09-09 23:30:20 UTC) #10
palmer
lgtm
5 years, 3 months ago (2015-09-09 23:37:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327743002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327743002/80001
5 years, 3 months ago (2015-09-22 16:15:47 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 3 months ago (2015-09-22 16:44:20 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 16:44:51 UTC) #16
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7e0fac6e1d8c79e7658a94e96a3f0246dc541d82
Cr-Commit-Position: refs/heads/master@{#350170}

Powered by Google App Engine
This is Rietveld 408576698