Fix chromeos=1 so Pulse is preferred when use_cras=0.

Fix chromeos=1 so Pulse is preferred when use_cras=0.

Merges the settings for use_alsa and use_pulseaudio for selection
based on use_cras.  As a consequence, removes linking of ALSA when
use_cras=1, which should result in a small binary size savings.

BUG=none
TEST=Pulse is available along with ALSA when chromeos=1.
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244098

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244251

[xhwang, 2014-01-09 22:59:22]

lgtm

[dgreid, 2014-01-09 23:02:37]

lgtm

[commit-bot: I haz the power, 2014-01-09 23:24:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/132773002/1

[commit-bot: I haz the power, 2014-01-10 01:23:18]

Retried try job too often on linux_aura for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2014-01-10 01:29:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/132773002/1

[commit-bot: I haz the power, 2014-01-10 05:09:51]

Change committed as 244098

[DaleCurtis, 2014-01-10 19:44:14]

dgreid: PTAL.  Previous patch was reverted due to cras's tangential dependency
on alsa_util.h.  I've broken this dependency in favor of including
"cras_types.h" directly.

https://codereview.chromium.org/132773002/diff/360001/media/audio/cras/cras_u...
File media/audio/cras/cras_unified_unittest.cc (right):

https://codereview.chromium.org/132773002/diff/360001/media/audio/cras/cras_u...
media/audio/cras/cras_unified_unittest.cc:49:
MOCK_METHOD3(MakeLowLatencyOutputStream,
I'm surprised this was broken... I guess we're not building media_unittests
anywhere use_cras=1 :(

[dgreid, 2014-01-10 19:56:25]

well, that got a lot bigger, lgtm

https://codereview.chromium.org/132773002/diff/360001/media/audio/cras/cras_i...
File media/audio/cras/cras_input_unittest.cc (right):

https://codereview.chromium.org/132773002/diff/360001/media/audio/cras/cras_i...
media/audio/cras/cras_input_unittest.cc:19: #endif
This works, we should probably wrap the defines in cras_util with ifndefs.

[DaleCurtis, 2014-01-10 20:00:18]

https://codereview.chromium.org/132773002/diff/360001/media/audio/cras/cras_i...
File media/audio/cras/cras_input_unittest.cc (right):

https://codereview.chromium.org/132773002/diff/360001/media/audio/cras/cras_i...
media/audio/cras/cras_input_unittest.cc:19: #endif
On 2014/01/10 19:56:25, dgreid wrote:
> This works, we should probably wrap the defines in cras_util with ifndefs.

Agreed, this isn't first time this issue has cropped up.  Although I guess no
bot will actually hit it since the tests aren't built anywhere where use_cras=1.

[commit-bot: I haz the power, 2014-01-10 21:44:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/132773002/360001

[commit-bot: I haz the power, 2014-01-10 21:59:47]

Change committed as 244251