Fix chromeos=1 so Pulse is preferred when use_cras=0.

media/audio/cras/cras_input_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include <unistd.h>
-
 #include <string>
 
 #include "base/synchronization/waitable_event.h"
 #include "base/test/test_timeouts.h"
 #include "base/time/time.h"
 #include "media/audio/cras/audio_manager_cras.h"
-#include "media/audio/cras/cras_input.h"
 #include "media/audio/fake_audio_log_factory.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
+// cras_util.h defines custom min/max macros which break compilation, so ensure
+// it's not included until last.  #if avoids presubmit errors.
+#if defined(USE_CRAS)
+#include "media/audio/cras/cras_input.h"
+#endif

[dgreid, 2014/01/10 19:56:25]

This works, we should probably wrap the defines in cras_util with ifndefs.

[DaleCurtis, 2014/01/10 20:00:18]

Agreed, this isn't first time this issue has cropped up.  Although I guess no
bot will actually hit it since the tests aren't built anywhere where use_cras=1.

+
 using testing::_;
 using testing::AtLeast;
 using testing::Ge;
 using testing::InvokeWithoutArgs;
 using testing::StrictMock;
 
 namespace media {
 
 class MockAudioInputCallback : public AudioInputStream::AudioInputCallback {
  public:
@@ skipping 180 matching lines @@
     AudioParameters params_stereo(kTestFormat,
                                   CHANNEL_LAYOUT_STEREO,
                                   rates[i],
                                   kTestBitsPerSample,
                                   kTestFramesPerPacket);
     CaptureSomeFrames(params_stereo, kTestCaptureDurationMs);
   }
 }
 
 }  // namespace media