[Chromecast] Raises CastService creation to CastContentBrowserClient.

chromecast/browser/cast_browser_main_parts.cc

Index: chromecast/browser/cast_browser_main_parts.cc
diff --git a/chromecast/browser/cast_browser_main_parts.cc b/chromecast/browser/cast_browser_main_parts.cc
index 9aaf7378bff8641c0f0c1efea6f4d9a3882b4d30..908cef1d2e4990dbf779ff4760c0f2d1b7bbae17 100644
--- a/chromecast/browser/cast_browser_main_parts.cc
+++ b/chromecast/browser/cast_browser_main_parts.cc
@@ -25,6 +25,7 @@
 #include "chromecast/base/metrics/grouped_histogram.h"
 #include "chromecast/browser/cast_browser_context.h"
 #include "chromecast/browser/cast_browser_process.h"
+#include "chromecast/browser/cast_content_browser_client.h"
 #include "chromecast/browser/cast_net_log.h"
 #include "chromecast/browser/devtools/remote_debugging_server.h"
 #include "chromecast/browser/metrics/cast_metrics_prefs.h"
@@ -334,11 +335,11 @@ void CastBrowserMainParts::PreMainMessageLoopRun() {
       base::Bind(&media::CastMediaShlib::Initialize, cmd_line->argv()));
   ::media::InitializeMediaLibrary();
 
-  cast_browser_process_->SetCastService(CastService::Create(
-      cast_browser_process_->browser_context(),
-      cast_browser_process_->pref_service(),
-      cast_browser_process_->metrics_service_client(),

[byungchul, 2015/09/01 23:18:01]

Remove only metrics service client because others are accessed by other places?
Wonder which singleton is better between CastService and CastBrowserProcess.

[gunsch, 2015/09/01 23:42:49]

Hmm, good question. I'd like to eventually eliminate BrowserContext and
MetricsServiceClient from being passed to ChromecastService, since both are
content/ dependencies.

I think originally MetricsServiceClient was added for CastServiceAndroid, which
is no longer necessary. So that's why I removed it.

-      url_request_context_factory_->GetSystemGetter()));
+  cast_browser_process_->SetCastService(
+      cast_browser_process_->browser_client()->CreateCastService(
+          cast_browser_process_->browser_context(),
+          cast_browser_process_->pref_service(),
+          url_request_context_factory_->GetSystemGetter()));
   cast_browser_process_->cast_service()->Initialize();
 
   // Initializing metrics service and network delegates must happen after cast