Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1327653004: Have uses of MockImageResourceClient leak less. (Closed)

Created:
5 years, 3 months ago by sof
Modified:
5 years, 3 months ago
Reviewers:
haraken, Nate Chapin, Nico
CC:
blink-reviews, Yoav Weiss, Nate Chapin, gavinp+loader_chromium.org, tyoshino+watch_chromium.org, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Have uses of MockImageResourceClient leak less. Turn this unit test helper into something more RAII-like to avoid Resources not having their clients removed. For the tests touched, addresses reported Resource leaks. R=haraken BUG=526423 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201645

Patch Set 1 #

Patch Set 2 : more leak fixes #

Patch Set 3 : Clean up MockImageResourceClient somewhat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -58 lines) Patch
M Source/core/core.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/fetch/ImageResourceTest.cpp View 1 2 6 chunks +8 lines, -10 lines 0 comments Download
M Source/core/fetch/MemoryCacheTest.cpp View 8 chunks +8 lines, -20 lines 0 comments Download
M Source/core/fetch/MockImageResourceClient.h View 1 2 1 chunk +11 lines, -14 lines 0 comments Download
A Source/core/fetch/MockImageResourceClient.cpp View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
M Source/core/fetch/RawResourceTest.cpp View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/fetch/ResourceFetcherTest.cpp View 1 4 chunks +9 lines, -4 lines 0 comments Download
M Source/core/frame/ImageBitmapTest.cpp View 1 2 2 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look.
5 years, 3 months ago (2015-09-02 09:41:41 UTC) #2
haraken
LGTM
5 years, 3 months ago (2015-09-02 09:47:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327653004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327653004/40001
5 years, 3 months ago (2015-09-02 13:21:14 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 14:29:05 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201645

Powered by Google App Engine
This is Rietveld 408576698