Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1387)

Side by Side Diff: Source/core/fetch/MockImageResourceClient.h

Issue 1327653004: Have uses of MockImageResourceClient leak less. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Clean up MockImageResourceClient somewhat Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/fetch/MemoryCacheTest.cpp ('k') | Source/core/fetch/MockImageResourceClient.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013, Google Inc. All rights reserved. 2 * Copyright (c) 2013, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 15 matching lines...) Expand all
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef MockImageResourceClient_h 31 #ifndef MockImageResourceClient_h
32 #define MockImageResourceClient_h 32 #define MockImageResourceClient_h
33 33
34 #include "core/fetch/ImageResourceClient.h" 34 #include "core/fetch/ImageResourceClient.h"
35 35
36 #include <gtest/gtest.h> 36 namespace blink {
37 37
38 namespace blink { 38 template<typename T> class ResourcePtr;
39
40 class Resource;
39 41
40 class MockImageResourceClient final : public ImageResourceClient { 42 class MockImageResourceClient final : public ImageResourceClient {
41 public: 43 public:
42 MockImageResourceClient() 44 explicit MockImageResourceClient(const ResourcePtr<Resource>&);
43 : m_imageChangedCount(0) 45 ~MockImageResourceClient() override;
44 , m_notifyFinishedCalled(false)
45 {
46 }
47 46
48 ~MockImageResourceClient() override {}
49 void imageChanged(ImageResource*, const IntRect*) override 47 void imageChanged(ImageResource*, const IntRect*) override
50 { 48 {
51 m_imageChangedCount++; 49 m_imageChangedCount++;
52 } 50 }
53 51
54 void notifyFinished(Resource*) override 52 void notifyFinished(Resource*) override;
55 {
56 ASSERT_FALSE(m_notifyFinishedCalled);
57 m_notifyFinishedCalled = true;
58 }
59 53
60 int imageChangedCount() const { return m_imageChangedCount; } 54 int imageChangedCount() const { return m_imageChangedCount; }
61 bool notifyFinishedCalled() const { return m_notifyFinishedCalled; } 55 bool notifyFinishedCalled() const { return m_notifyFinishedCalled; }
62 56
57 void removeAsClient();
58
63 private: 59 private:
60 Resource* m_resource;
64 int m_imageChangedCount; 61 int m_imageChangedCount;
65 bool m_notifyFinishedCalled; 62 bool m_notifyFinishedCalled;
66 }; 63 };
67 64
68 } // namespace blink 65 } // namespace blink
69 66
70 #endif // ImageResourceTest_h 67 #endif // MockImageResourceClient_h
OLDNEW
« no previous file with comments | « Source/core/fetch/MemoryCacheTest.cpp ('k') | Source/core/fetch/MockImageResourceClient.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698