Trying to reland the patch originally commited here:

Trying to reland the patch originally commited here:
https://codereview.chromium.org/79673003
and reverted here:
https://codereview.chromium.org/120323002/

I think the build failure was because "browser" target should depend
on "cast_channel_proto" so that cast_channel.pb.h is built before
browser target is built.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247549

[Munjal (Google), 2014-01-09 22:58:38]

Mark and Wez, this is the same patch as before but with one extra file:
chrome_browser.gypi with the appropriate dependency added.

[mark a. foltz, 2014-01-09 23:15:08]

On 2014/01/09 22:58:38, Munjal (Google) wrote:
> Mark and Wez, this is the same patch as before but with one extra file:
> chrome_browser.gypi with the appropriate dependency added.

Per IM, this dependency looks redundant, so let's dig further and figure out
what is going on.

[Munjal (Google), 2014-01-22 18:11:24]

I removed the BUILD file from the patch. So this patch is now identical to the
original reverted patch. I don't see any try bot issues. So I will just try the
patch as is.

[mark a. foltz, 2014-01-22 21:45:53]

lgtm

[commit-bot: I haz the power, 2014-01-23 18:16:17]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Wez, 2014-01-23 18:17:53]

lgtm

[commit-bot: I haz the power, 2014-01-23 18:21:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/munjal@chromium.org/132763002/260001

[commit-bot: I haz the power, 2014-01-23 19:58:57]

Retried try job too often on linux_chromeos for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2014-01-24 18:15:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/munjal@chromium.org/132763002/260001

[commit-bot: I haz the power, 2014-01-24 20:01:52]

Retried try job too often on linux_chromeos for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2014-01-28 21:29:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/munjal@chromium.org/132763002/260001

[commit-bot: I haz the power, 2014-01-29 00:56:39]

Change committed as 247549

[Ami GONE FROM CHROMIUM, 2014-01-31 07:08:40]

This CL introduces a flaky build breakage.  To observe it, blow away your out/
directory and run:
./build/gyp_chromium
ninja -C out/Debug
obj/chrome/common/extensions/api/gen/chrome/common/extensions/api/api.generated_api.o

The brokenness looks like this:
In file included from gen/chrome/common/extensions/api/generated_api.cc:58:
In file included from
../../chrome/browser/extensions/api/cast_channel/cast_channel_api.h:13:
../../chrome/browser/extensions/api/cast_channel/cast_socket.h:19:10: fatal
error: 'chrome/browser/extensions/api/cast_channel/cast_channel.pb.h' file not
found
#include "chrome/browser/extensions/api/cast_channel/cast_channel.pb.h"
         ^
1 error generated.


and is caused by the fact that while  chrome/common/extensions/api/api.gyp
previously depended on cast_socket.h through cast_channel_api.h, now
cast_socket.h introduces a dependency on cast_channel_proto which isn't
accounted for in api.gyp.  The brokenness is flaky because if the build system
happens to have build cast_channel_proto before trying to build the api target,
everything will appear fine.

An easy workaround for this particular breakage is to make the 'api' target
depend on '<(DEPTH)/chrome/chrome.gyp:cast_channel_proto':
diff --git a/chrome/common/extensions/api/api.gyp
b/chrome/common/extensions/api/api.gyp
index b6dfc90..c2a1ce5 100644
--- a/chrome/common/extensions/api/api.gyp
+++ b/chrome/common/extensions/api/api.gyp
@@ -177,6 +177,7 @@
         'root_namespace': 'extensions::api',
       },
       'dependencies': [
+        '<(DEPTH)/chrome/chrome.gyp:cast_channel_proto',
         '<(DEPTH)/skia/skia.gyp:skia',
         '<(DEPTH)/sync/sync.gyp:sync',
       ],

I don't know any of this code well enough to say whether this is a proper
dependency to introduce.

Please either roll back this CL or fix the flake properly.