Issue 1327523007: Merge to XFA: Change the JS app.viewerType() return value to "pdfium"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1327523007: Merge to XFA: Change the JS app.viewerType() return value to "pdfium" (Closed)

Created:
5 years, 3 months ago by Lei Zhang

Modified:
5 years, 3 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Change the JS app.viewerType() return value to "pdfium" BUG=pdfium:181 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1331633002 . (cherry picked from commit 4bc64cabc561d5df211ed02dc75c85e41fa91312) Committed: https://pdfium.googlesource.com/pdfium/+/96675b148c8961242e2e1f91a300fd9b15068bdf

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -4 lines)			Patch
M	fpdfsdk/src/javascript/app.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	testing/resources/javascript/app_alert.in	View	1 chunk	+1 line, -1 line	0 comments	Download
M	testing/resources/javascript/app_alert_expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	testing/resources/javascript/app_props.in	View	1 chunk	+1 line, -1 line	0 comments	Download
A	testing/resources/javascript/app_props_expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

5 years, 3 months ago (2015-09-08 22:30:29 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
96675b148c8961242e2e1f91a300fd9b15068bdf (presubmit successful).