Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 1331633002: Change the JS app.viewerType() return value to "pdfium" (Closed)

Created:
5 years, 3 months ago by Lei Zhang
Modified:
5 years, 3 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : app_props.in #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M fpdfsdk/src/javascript/app.cpp View 1 chunk +1 line, -1 line 0 comments Download
M testing/resources/javascript/app_alert.in View 1 chunk +1 line, -1 line 0 comments Download
M testing/resources/javascript/app_alert_expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + testing/resources/javascript/app_props.in View 1 1 chunk +1 line, -1 line 0 comments Download
A testing/resources/javascript/app_props_expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Lei Zhang
Let me know if we need this separate test file or if we should just ...
5 years, 3 months ago (2015-09-08 21:45:06 UTC) #2
Tom Sepez
On 2015/09/08 21:45:06, Lei Zhang wrote: > Let me know if we need this separate ...
5 years, 3 months ago (2015-09-08 21:48:43 UTC) #3
Tom Sepez
On 2015/09/08 21:45:06, Lei Zhang wrote: > Let me know if we need this separate ...
5 years, 3 months ago (2015-09-08 21:48:44 UTC) #4
Tom Sepez
Otherwise LGTM.
5 years, 3 months ago (2015-09-08 21:50:50 UTC) #5
Lei Zhang
app_props.in it is
5 years, 3 months ago (2015-09-08 22:17:47 UTC) #6
Lei Zhang
5 years, 3 months ago (2015-09-08 22:17:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4bc64cabc561d5df211ed02dc75c85e41fa91312 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698