Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1327483002: Stage sloppy let (Closed)

Created:
5 years, 3 months ago by Dan Ehrenberg
Modified:
5 years, 3 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Stage sloppy let Move the --harmony-sloppy-let flag to staging for further testing, and update test262 for the new passing tests. Also increase the strictness of the parser, even in sloppy mode, to disallow "new legacy compat" for for (let x = 5 in {}) {} which is now a SyntaxError. BUG=v8:3305 LOG=Y R=adamk Committed: https://crrev.com/07bc0117be8dc9e63ec14d5f9645c483d60a1bec Cr-Commit-Position: refs/heads/master@{#30515}

Patch Set 1 #

Patch Set 2 : test262 update #

Patch Set 3 : test262 update and make parser more strict #

Patch Set 4 : all const tests still disabled #

Patch Set 5 : more test failures #

Patch Set 6 : tests #

Patch Set 7 : another test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -67 lines) Patch
M src/flag-definitions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/parser.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M test/test262-es6/test262-es6.status View 1 2 3 4 5 6 2 chunks +13 lines, -64 lines 0 comments Download

Messages

Total messages: 31 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327483002/1
5 years, 3 months ago (2015-08-31 21:05:00 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327483002/20001
5 years, 3 months ago (2015-08-31 21:26:35 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/9266)
5 years, 3 months ago (2015-08-31 21:54:55 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327483002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327483002/40001
5 years, 3 months ago (2015-08-31 22:33:15 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/9270)
5 years, 3 months ago (2015-08-31 23:00:57 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327483002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327483002/60001
5 years, 3 months ago (2015-08-31 23:16:15 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/9274)
5 years, 3 months ago (2015-08-31 23:45:30 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327483002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327483002/80001
5 years, 3 months ago (2015-09-01 02:18:34 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/9277)
5 years, 3 months ago (2015-09-01 02:48:50 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327483002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327483002/100001
5 years, 3 months ago (2015-09-01 03:21:56 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327483002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327483002/120001
5 years, 3 months ago (2015-09-01 03:42:30 UTC) #22
Dan Ehrenberg
5 years, 3 months ago (2015-09-01 04:08:46 UTC) #23
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-01 04:20:30 UTC) #25
adamk
lgtm
5 years, 3 months ago (2015-09-01 15:47:54 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327483002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327483002/120001
5 years, 3 months ago (2015-09-01 15:56:13 UTC) #28
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 3 months ago (2015-09-01 15:57:39 UTC) #29
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/07bc0117be8dc9e63ec14d5f9645c483d60a1bec Cr-Commit-Position: refs/heads/master@{#30515}
5 years, 3 months ago (2015-09-01 15:57:58 UTC) #30
Dan Ehrenberg
5 years, 3 months ago (2015-09-01 17:36:25 UTC) #31
Message was sent while issue was closed. 
A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/1324033002/ by littledan@chromium.org.

The reason for reverting is: Fails a test262 test with --always-opt..

Powered by Google App Engine
This is Rietveld 408576698