Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1324033002: Revert of Stage sloppy let (Closed)

Created:
5 years, 3 months ago by Dan Ehrenberg
Modified:
5 years, 3 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Stage sloppy let (patchset #7 id:120001 of https://codereview.chromium.org/1327483002/ ) Reason for revert: Fails a test262 test with --always-opt. Original issue's description: > Stage sloppy let > > Move the --harmony-sloppy-let flag to staging for further testing, and > update test262 for the new passing tests. Also increase the strictness > of the parser, even in sloppy mode, to disallow "new legacy compat" for > > for (let x = 5 in {}) {} > > which is now a SyntaxError. > > BUG=v8:3305 > LOG=Y > R=adamk > > Committed: https://crrev.com/07bc0117be8dc9e63ec14d5f9645c483d60a1bec > Cr-Commit-Position: refs/heads/master@{#30515} TBR=adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3305 Committed: https://crrev.com/d1fa7bccc80ce67ab52cbbd3daadeeab47a365c9 Cr-Commit-Position: refs/heads/master@{#30518}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -17 lines) Patch
M src/flag-definitions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/parser.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/test262-es6/test262-es6.status View 2 chunks +64 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Ehrenberg
Created Revert of Stage sloppy let
5 years, 3 months ago (2015-09-01 17:36:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324033002/1
5 years, 3 months ago (2015-09-01 17:36:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 17:36:57 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 17:37:16 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1fa7bccc80ce67ab52cbbd3daadeeab47a365c9
Cr-Commit-Position: refs/heads/master@{#30518}

Powered by Google App Engine
This is Rietveld 408576698