Issue 1327473002: Fix two issues shown by bug 489995

Issue 1327473002: Fix two issues shown by bug 489995 (Closed)

Created:
5 years, 3 months ago by Tom Sepez

Modified:
5 years, 3 months ago

Reviewers:
Lei Zhang, brucedawson

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix two issues shown by bug 489995 - Handle NULL in buffer operator<< under JS mailForm() calls. - Ensure correct type in JS addIcon() calls. BUG=489995 R=brucedawson@chromium.org, thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6e369c2ebb4769a42736b32154c0de12b73df45d

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/javascript/Document.cpp	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	testing/resources/javascript/document_methods.in	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	testing/resources/javascript/document_methods_expected.txt	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 7 (1 generated)

brucedawson

I can't really comment on the Document.cpp fix, but the other fix lgtm.

5 years, 3 months ago (2015-08-31 20:55:51 UTC) #3

Lei Zhang

lgtm Since I already have http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/js_api_reference.pdf open today, I looked up addIcon...

5 years, 3 months ago (2015-08-31 21:34:21 UTC) #4

Tom Sepez

Just for laughs, added a test case that fails currently without the patch for the ...

5 years, 3 months ago (2015-08-31 21:42:45 UTC) #5

Tom Sepez

5 years, 3 months ago (2015-08-31 21:44:25 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
6e369c2ebb4769a42736b32154c0de12b73df45d (presubmit successful).