testing/resources/javascript/document_methods.in - Issue 1327473002: Fix two issues shown by bug 489995

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/resources/javascript/document_methods.in

Issue 1327473002: Fix two issues shown by bug 489995 (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Add test for addIcon() Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: testing/resources/javascript/document_methods.in

diff --git a/testing/resources/javascript/document_methods.in b/testing/resources/javascript/document_methods.in

index b2467f37c4f02ded457c3dd060acc9339e4dc73b..3cd3330b878d22ef0fdfd1e865cce092f5df5607 100644

--- a/testing/resources/javascript/document_methods.in

+++ b/testing/resources/javascript/document_methods.in

@@ -122,6 +122,7 @@ function testAddIcon() {

// Second argument must actually be an icon.

expectError('this.addIcon("myicon", 3)');

+ expectError('this.addIcon("myicon", undefined)');

// TODO(tsepez): test success cases.

}