Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1327363003:
Roll buildtools in DEPS 565d04e874..f7310ee617 (Closed)
|
Created:
5 years, 3 months ago by Dirk Pranke Modified:
5 years, 3 months ago Reviewers:
brettw CC:
chromium-reviews, tfarina Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll buildtools in DEPS 565d04e874..f7310ee617
In order to roll GN a6029a4c14..4c8f3e38da (r341627:r348227) and pick up
the following changes:
a88eb18 Throw errors for nested targets in GN.
d9838e1 Make gyp_flag_compare.py work on Windows
63a4d15 Fix sbox_validation_tests & Make isolate_driver.py include the executable itself
789ee89 gn: fix documentation typo
3473904 Update reference doc page for GN.
d2cb755 GN: Fix bootstrap script on Mac.
7c8964f Revert of Fix sbox_validation_tests & Make isolate_driver.py include the executable itself (patchset #3 id:90001 of https://codereview.chromium.org/1245873002/ )
c6649f2 Fix sbox_validation_tests & Make isolate_driver.py include the executable itself
5591967 tools/gn: Remove fallback to direct_dependent_configs.
fe59edc [GN] move gn doc to proper place
ba7a73d Annotate GN executables and shared_libraries with sanitizer deps.
6aeaa45 GN get_label_info support toolchains for target_out_dir.
7693bf2 Sync GN unit tests with GYP, add checking script.
28fccd5 Revert of Sync GN unit tests with GYP, add checking script. (patchset #3 id:40001 of https://codereview.chromium.org/1289423004/ )
b2f7271 Sync GN unit tests with GYP, add checking script.
7a694fe Fix various stray bugs in the GN auto-roller, and repair the DEPS file.
83dc161 Remove remaining legacy SplitString calls.
f51a763 tools/gn: Remove includes of basictypes.h.
b35ddf5 clang/win: Try to fix 64-bit build after https://codereview.chromium.org/1261953003.
e330570 clang/win: Try to fix build after https://codereview.chromium.org/1261953003.
c9b8dab Fix gn bootstrap.
693c605 Fix some crashes in GN.
2a08763 Pull ICU, rename component build GN variables.
d79f1ac Reference written files relatively when possible.
R=brettw@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel
Committed: https://crrev.com/d67e27fd3ae403cd6d97015143a8e7841de0dadb
Cr-Commit-Position: refs/heads/master@{#348787}
Patch Set 1 #Patch Set 2 : revert roll_gn change #Patch Set 3 : rebase #Patch Set 4 : un-nest IAccessible2Proxy_warnings #Messages
Total messages: 42 (19 generated)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327363003/1
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327363003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327363003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327363003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327363003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
lgtm
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327363003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327363003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_gn_x64_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_gn_x...)
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327363003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327363003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...) win_chromium_gn_x64_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_gn_x...)
The CQ bit was checked by dpranke@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org Link to the patchset: https://codereview.chromium.org/1327363003/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327363003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327363003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327363003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327363003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_gn_x64_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_gn_x...)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327363003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327363003/40001
The CQ bit was checked by dpranke@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org Link to the patchset: https://codereview.chromium.org/1327363003/#ps60001 (title: "un-nest IAccessible2Proxy_warnings")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327363003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327363003/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327363003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327363003/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/d67e27fd3ae403cd6d97015143a8e7841de0dadb Cr-Commit-Position: refs/heads/master@{#348787}
Message was sent while issue was closed.
Phew!
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/d67e27fd3ae403cd6d97015143a8e7841de0dadb Cr-Commit-Position: refs/heads/master@{#348787} |
