Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 1261953003: clang/win: Build chromium_code with -Wunused-function (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : try #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -23 lines) Patch
M build/common.gypi View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M media/audio/win/audio_device_listener_win.cc View 1 2 1 chunk +0 lines, -21 lines 0 comments Download
M win8/metro_driver/metro_driver.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Nico
Looks like this might work now. dalecurtis: media/ dcheng: build/
5 years, 4 months ago (2015-08-08 04:14:38 UTC) #2
dcheng
lgtm
5 years, 4 months ago (2015-08-08 04:58:58 UTC) #3
DaleCurtis
lgtm
5 years, 4 months ago (2015-08-08 05:58:35 UTC) #4
Nico
+robertshield for the release-only change in win8/
5 years, 4 months ago (2015-08-08 06:04:18 UTC) #6
robertshield
lgtm I
5 years, 4 months ago (2015-08-08 10:32:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261953003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261953003/60001
5 years, 4 months ago (2015-08-08 17:01:45 UTC) #10
Nico
5 years, 4 months ago (2015-08-08 17:40:49 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
0f942010a9bf8c335e5818b2ca228266b42cc725 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698