Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 132723003: [rAc - i18n] don't call callbacks on Storage destruction (Closed)

Created:
6 years, 11 months ago by Evan Stade
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[rAc - i18n] don't call callbacks on Storage destruction The leaks this would have caused before should now be fixed. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244097

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M third_party/libaddressinput/chromium/chrome_storage_impl.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Stade
6 years, 11 months ago (2014-01-09 22:54:58 UTC) #1
please use gerrit instead
lgtm
6 years, 11 months ago (2014-01-09 23:15:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/132723003/1
6 years, 11 months ago (2014-01-10 00:09:20 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 05:09:06 UTC) #4
Message was sent while issue was closed.
Change committed as 244097

Powered by Google App Engine
This is Rietveld 408576698