Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: third_party/libaddressinput/chromium/chrome_storage_impl.cc

Issue 132723003: [rAc - i18n] don't call callbacks on Storage destruction (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libaddressinput/chromium/chrome_storage_impl.cc
diff --git a/third_party/libaddressinput/chromium/chrome_storage_impl.cc b/third_party/libaddressinput/chromium/chrome_storage_impl.cc
index 1c731a903c8de9985d5d8361885a230d375e2e53..2cd8c01d9aec63a72cd7c63025e9cb9ac9aa0811 100644
--- a/third_party/libaddressinput/chromium/chrome_storage_impl.cc
+++ b/third_party/libaddressinput/chromium/chrome_storage_impl.cc
@@ -13,14 +13,7 @@ ChromeStorageImpl::ChromeStorageImpl(WriteablePrefStore* store)
scoped_observer_.Add(backing_store_);
}
-ChromeStorageImpl::~ChromeStorageImpl() {
- // TODO(estade): this shouldn't be necessary.
- for (std::vector<Request*>::iterator iter =
- outstanding_requests_.begin();
- iter != outstanding_requests_.end(); ++iter) {
- (*(*iter)->callback)(false, (*iter)->key, std::string());
- }
-}
+ChromeStorageImpl::~ChromeStorageImpl() {}
void ChromeStorageImpl::Put(const std::string& key, const std::string& data) {
backing_store_->SetValue(key, new base::StringValue(data));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698