Issue 132693017: Revert 245563 and 245800 which made re2 GN generated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132693017: Revert 245563 and 245800 which made re2 GN generated. (Closed)

Created:
6 years, 11 months ago by brettw

Modified:
6 years, 11 months ago

Reviewers:
Nico, (unused - use chromium)

CC:
chromium-reviews, extensions-reviews_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert 245563 and 245800 which made re2 GN generated. This change keeps the BUILD file in the new location and does not resort the .gyp files to facilitate relanding. TBR=thakis BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246255

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+105 lines, -18 lines)			Patch
build/all.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
chrome/chrome_browser.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
chrome/chrome_browser_chromeos.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
chrome/chrome_browser_extensions.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
chrome/chrome_browser_ui.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
chrome/chrome_common.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
chrome/chrome_renderer.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
chrome/tools/profile_reset/jtl_compiler.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
components/plugins.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
components/url_matcher.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
content/content_browser.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
extensions/extensions.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
gpu/command_buffer_service.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
gpu/gpu_config.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
third_party/leveldatabase/leveldatabase.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
third_party/libaddressinput/libaddressinput.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
third_party/re2/BUILD.gn	View	2 chunks	+4 lines, -1 line	0 comments	Download
third_party/re2/re2.gyp	View	1 chunk	+84 lines, -0 lines	0 comments	Download
tools/ipc_fuzzer/mutate/mutate.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

Committed patchset #1 manually as r246255 (presubmit successful).

6 years, 11 months ago (2014-01-22 09:28:08 UTC) #1

Nico

6 years, 11 months ago (2014-01-22 19:10:30 UTC) #2

Message was sent while issue was closed.

lgtm

Do you want to file a bug for relanding this and marking it blocked on the
things you consider critical? Maybe I can help with some of them.

Expand Messages | Collapse Messages