Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: third_party/re2/BUILD.gn

Issue 132693017: Revert 245563 and 245800 which made re2 GN generated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/libaddressinput/libaddressinput.gyp ('k') | third_party/re2/re2.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/re2/BUILD.gn
diff --git a/third_party/re2/BUILD.gn b/third_party/re2/BUILD.gn
index 9f3ba8d23c873186dfbedf9fa225d1cccecdc589..67b43784f9f96d4eb292bf8379d3d8c4e9e1fdc7 100644
--- a/third_party/re2/BUILD.gn
+++ b/third_party/re2/BUILD.gn
@@ -2,13 +2,15 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-gyp_file = "//$gyp_output_dir/gn_gyp/third_party/re2/re2.gyp"
+# TODO(brettw) use this value when we remove external=true below.
+#gyp_file = "//$gyp_output_dir/gn_gyp/third_party/re2/re2.gyp"
config("re2_config") {
include_dirs = [ "." ]
}
static_library("re2") {
+ external = true
sources = [
"mswin/stdint.h",
"re2/bitstate.cc",
@@ -69,6 +71,7 @@ static_library("re2") {
if (is_win) {
include_dirs = [ "mswin" ]
+ # TODO(brettw) 'msvs_disabled_warnings': [ 4018, 4722, 4267 ],
} else {
sources -= [ "mswin/stdint.h" ]
}
« no previous file with comments | « third_party/libaddressinput/libaddressinput.gyp ('k') | third_party/re2/re2.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698