Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 132683003: cc: Rename LayerImpl::DidLoseOutputSurface to ReleaseResources (Closed)

Created:
6 years, 11 months ago by boliu
Modified:
6 years, 11 months ago
Reviewers:
danakj
CC:
chromium-reviews, feature-media-reviews_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

cc: Rename LayerImpl::DidLoseOutputSurface to ReleaseResources For Android Webview using deferred gl initialization, calling this method does not indicate an error and does not necessarily mean the OutputSurface is lost. Purely mechanical change. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244636

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -33 lines) Patch
M cc/layers/delegated_renderer_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/delegated_renderer_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/heads_up_display_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/heads_up_display_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/heads_up_display_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/io_surface_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/io_surface_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer_impl.h View 1 chunk +3 lines, -4 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M cc/layers/texture_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/texture_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/tiled_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/tiled_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/video_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/video_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_content_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_content_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
boliu
Another mechanical clean up
6 years, 11 months ago (2014-01-10 05:51:32 UTC) #1
danakj
LGTM, thanks
6 years, 11 months ago (2014-01-13 19:39:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/132683003/1
6 years, 11 months ago (2014-01-13 19:40:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/132683003/1
6 years, 11 months ago (2014-01-13 23:36:19 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 02:26:02 UTC) #5
Message was sent while issue was closed. 
Change committed as 244636

Powered by Google App Engine
This is Rietveld 408576698