Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 1326813002: [Smart Lock] Remove unnecessary string duplication for autosign in smart lock UI. (Closed)

Created:
5 years, 3 months ago by melandory
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Remove unnecessary string duplication for autosign in smart lock UI. BUG=527168 Committed: https://crrev.com/b792116bf71f01665b37647a5944464cdbd53302 Cr-Commit-Position: refs/heads/master@{#347168}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Multyline snackbar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -14 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/snackbar/smartlockautosignin/AutoSigninSnackbarController.java View 1 2 2 chunks +3 lines, -8 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/android/snackbars/auto_signin_snackbar_controller.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
melandory
newt@chromium.org: Please review changes in chrome/android/java/src/org/chromium/chrome/browser/snackbar/smartlockautosignin/AutoSigninSnackbarController.java chrome/android/java/strings/android_chrome_strings.grd miguelg@chromium.org: Please review changes in chrome/browser/ui/android/snackbars/auto_signin_snackbar_controller.cc
5 years, 3 months ago (2015-09-02 15:18:48 UTC) #2
newt (away)
lgtm with comment https://codereview.chromium.org/1326813002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/snackbar/smartlockautosignin/AutoSigninSnackbarController.java File chrome/android/java/src/org/chromium/chrome/browser/snackbar/smartlockautosignin/AutoSigninSnackbarController.java (right): https://codereview.chromium.org/1326813002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/snackbar/smartlockautosignin/AutoSigninSnackbarController.java#newcode35 chrome/android/java/src/org/chromium/chrome/browser/snackbar/smartlockautosignin/AutoSigninSnackbarController.java:35: snackbarManager.showSnackbar(Snackbar.make(text, snackbar)); Now that you're no ...
5 years, 3 months ago (2015-09-02 16:49:08 UTC) #3
melandory
Hey tedchoc@, maybe you can have a look at autosignin_snackbar_controller.cc. Thanks in advance.
5 years, 3 months ago (2015-09-03 12:26:13 UTC) #5
Ted C
lgtm
5 years, 3 months ago (2015-09-03 16:57:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326813002/40001
5 years, 3 months ago (2015-09-03 17:02:48 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-03 17:09:12 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 17:10:06 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b792116bf71f01665b37647a5944464cdbd53302
Cr-Commit-Position: refs/heads/master@{#347168}

Powered by Google App Engine
This is Rietveld 408576698