Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4380)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/snackbar/smartlockautosignin/AutoSigninSnackbarController.java

Issue 1326813002: [Smart Lock] Remove unnecessary string duplication for autosign in smart lock UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Multyline snackbar Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/snackbar/smartlockautosignin/AutoSigninSnackbarController.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/smartlockautosignin/AutoSigninSnackbarController.java b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/smartlockautosignin/AutoSigninSnackbarController.java
index ff34151ac02fe173d366be3bd7443aacc0031db3..8feab86736383d339c5f10c062d9dcde00170a83 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/smartlockautosignin/AutoSigninSnackbarController.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/smartlockautosignin/AutoSigninSnackbarController.java
@@ -4,10 +4,7 @@
package org.chromium.chrome.browser.snackbar.smartlockautosignin;
-import android.content.Context;
-
import org.chromium.base.annotations.CalledByNative;
-import org.chromium.chrome.R;
import org.chromium.chrome.browser.snackbar.Snackbar;
import org.chromium.chrome.browser.snackbar.SnackbarManager;
import org.chromium.chrome.browser.tab.EmptyTabObserver;
@@ -27,17 +24,15 @@ public class AutoSigninSnackbarController
/**
* Displays Auto sign-in snackbar, which communicates to the users that they
- * were signed in to the web site. Displays the |username| in the message.
+ * were signed in to the web site.
*/
@CalledByNative
- private static void showSnackbar(Tab tab, String username) {
+ private static void showSnackbar(Tab tab, String text) {
SnackbarManager snackbarManager = tab.getSnackbarManager();
if (snackbarManager == null) return;
AutoSigninSnackbarController snackbar =
new AutoSigninSnackbarController(snackbarManager, tab);
- Context context = tab.getWindowAndroid().getApplicationContext();
- String text = context.getString(R.string.passwords_auto_signin_message);
- snackbarManager.showSnackbar(Snackbar.make(username, snackbar).setTemplateText(text));
+ snackbarManager.showSnackbar(Snackbar.make(text, snackbar).setSingleLine(false));
}
/**
« no previous file with comments | « no previous file | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698