Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 1326793002: [heap] Separate ObjectStats out into its own class. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
Michael Lippautz
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Separate ObjectStats out into its own class. Note that this is only pulling out the bookkeeping side of things, the marking visitor that actually records the statistics should also move into the ObjectStats class. That will be done as a follow-up. R=mlippautz@chromium.org Committed: https://crrev.com/c7de3e7f27fb4068191a6434f47d20191e676ed6 Cr-Commit-Position: refs/heads/master@{#30547}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -214 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M src/heap/heap.h View 8 chunks +22 lines, -60 lines 0 comments Download
M src/heap/heap.cc View 8 chunks +40 lines, -133 lines 0 comments Download
M src/heap/mark-compact.cc View 8 chunks +20 lines, -17 lines 0 comments Download
A src/heap/object-stats.h View 1 chunk +86 lines, -0 lines 0 comments Download
A src/heap/object-stats.cc View 1 chunk +138 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 3 months ago (2015-09-02 14:35:56 UTC) #1
Michael Lippautz
lgtm
5 years, 3 months ago (2015-09-02 16:32:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326793002/1
5 years, 3 months ago (2015-09-02 16:42:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-02 16:43:29 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 16:43:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7de3e7f27fb4068191a6434f47d20191e676ed6
Cr-Commit-Position: refs/heads/master@{#30547}

Powered by Google App Engine
This is Rietveld 408576698