Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1310953008: [heap] Move ObjectStatsVisitor into the proper component. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
Michael Lippautz
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-heap-object-stats-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Move ObjectStatsVisitor into the proper component. This is a follow-up to a previous change and moved object statistics tracking into its own component. It is no longer intertwinded with the normal marking logic, but separated out into ObjectStatsVisitor. R=mlippautz@chromium.org Committed: https://crrev.com/310f2ece0f78d698e606e8166cfb13107ebc65d2 Cr-Commit-Position: refs/heads/master@{#30548}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -151 lines) Patch
M src/heap/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +1 line, -151 lines 0 comments Download
M src/heap/object-stats.h View 1 chunk +15 lines, -0 lines 0 comments Download
M src/heap/object-stats.cc View 1 chunk +120 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 3 months ago (2015-09-02 15:32:27 UTC) #1
Michael Lippautz
lgtm, thanks a lot!
5 years, 3 months ago (2015-09-02 16:55:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310953008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310953008/1
5 years, 3 months ago (2015-09-02 16:57:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-02 17:09:49 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 17:10:07 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/310f2ece0f78d698e606e8166cfb13107ebc65d2
Cr-Commit-Position: refs/heads/master@{#30548}

Powered by Google App Engine
This is Rietveld 408576698