Issue 1326733003: cc: Workaround resourceless draw crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1326733003: cc: Workaround resourceless draw crash (Closed)

Created:
5 years, 3 months ago by boliu

Modified:
5 years, 3 months ago

Reviewers:
boliu

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2454

Target Ref:
refs/pending/branch-heads/2454

Project:
chromium

Visibility:
Public.

More Reviews

Description

cc: Workaround resourceless draw crash It's possible for resourceless draw to raster a layer with no recording, which crashes in DisplayListRasterSource::RasterCommon. Workaround this by not appending picture quad if there is no recording for that layer. Small patch for merging back to release. BUG=526402 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1326713002 Cr-Commit-Position: refs/heads/master@{#346760} (cherry picked from commit d16632eaf7354c9f277e7a7ee4ef666ce186d562) TBR=boliu@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/1fb1d22c930b1421509b702b62623e3dd8c8c04c

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	cc/layers/picture_layer_impl.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

boliu

5 years, 3 months ago (2015-09-01 23:03:03 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1fb1d22c930b1421509b702b62623e3dd8c8c04c (presubmit successful).

Expand Messages | Collapse Messages