Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: cc/layers/picture_layer_impl.cc

Issue 1326733003: cc: Workaround resourceless draw crash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2454
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/picture_layer_impl.cc
diff --git a/cc/layers/picture_layer_impl.cc b/cc/layers/picture_layer_impl.cc
index c7076bdc1e1d7633eb829aa6b54d34507ea4de25..90fdeb1efb4e1f58564e9a7f4f44bed707907412 100644
--- a/cc/layers/picture_layer_impl.cc
+++ b/cc/layers/picture_layer_impl.cc
@@ -183,7 +183,9 @@ void PictureLayerImpl::AppendQuads(RenderPass* render_pass,
gfx::Rect opaque_rect = contents_opaque() ? geometry_rect : gfx::Rect();
gfx::Rect visible_geometry_rect =
scaled_occlusion.GetUnoccludedContentRect(geometry_rect);
- if (visible_geometry_rect.IsEmpty())
+ // TODO(enne): HasRecordings is a workaround for crash in crbug.com/526402.
+ // Need proper fix for when recording does not cover visible rect.
+ if (visible_geometry_rect.IsEmpty() || !raster_source_->HasRecordings())
return;
gfx::Rect quad_content_rect = shared_quad_state->visible_quad_layer_rect;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698