Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: Source/core/editing/VisibleUnits.cpp

Issue 1326563002: Introduce visiblePositionOf() with PositionWithAffinity as replacement of VisiblePosition constructo (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-09-01T10:55:04 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/VisibleSelection.cpp ('k') | Source/core/frame/LocalFrame.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/VisibleUnits.cpp
diff --git a/Source/core/editing/VisibleUnits.cpp b/Source/core/editing/VisibleUnits.cpp
index 65353feb5cc9d42d40ab4bb5f92ab93931693fe0..f0a1047caa0a665ba8339f320ceb7b8dea6b1925 100644
--- a/Source/core/editing/VisibleUnits.cpp
+++ b/Source/core/editing/VisibleUnits.cpp
@@ -814,12 +814,12 @@ static PositionInComposedTreeWithAffinity startOfLine(const PositionInComposedTr
// FIXME: Rename this function to reflect the fact it ignores bidi levels.
VisiblePosition startOfLine(const VisiblePosition& currentPosition)
{
- return VisiblePosition(startOfLine(currentPosition.toPositionWithAffinity(), UseInlineBoxOrdering));
+ return visiblePositionOf(startOfLine(currentPosition.toPositionWithAffinity(), UseInlineBoxOrdering));
}
VisiblePosition logicalStartOfLine(const VisiblePosition& currentPosition)
{
- return VisiblePosition(startOfLine(currentPosition.toPositionWithAffinity(), UseLogicalOrdering));
+ return visiblePositionOf(startOfLine(currentPosition.toPositionWithAffinity(), UseLogicalOrdering));
}
static VisiblePosition endPositionForLine(const VisiblePosition& c, LineEndpointComputationMode mode)
@@ -1029,7 +1029,7 @@ VisiblePosition previousLinePosition(const VisiblePosition& visiblePosition, Lay
Node* node = layoutObject.node();
if (node && editingIgnoresContent(node))
return VisiblePosition(positionInParentBeforeNode(*node));
- return VisiblePosition(layoutObject.positionForPoint(pointInLine));
+ return visiblePositionOf(layoutObject.positionForPoint(pointInLine));
}
// Could not find a previous line. This means we must already be on the first line.
@@ -1085,7 +1085,7 @@ VisiblePosition nextLinePosition(const VisiblePosition& visiblePosition, LayoutU
Node* node = layoutObject.node();
if (node && editingIgnoresContent(node))
return VisiblePosition(positionInParentBeforeNode(*node));
- return VisiblePosition(layoutObject.positionForPoint(pointInLine));
+ return visiblePositionOf(layoutObject.positionForPoint(pointInLine));
}
// Could not find a next line. This means we must already be on the last line.
« no previous file with comments | « Source/core/editing/VisibleSelection.cpp ('k') | Source/core/frame/LocalFrame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698