Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: snapshot/win/process_snapshot_win.h

Issue 1326443007: win: Fix incorrect thread suspend count due to ScopedProcessSuspend (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: assert some threads captured Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/win/process_reader_win_test.cc ('k') | snapshot/win/process_snapshot_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/win/process_snapshot_win.h
diff --git a/snapshot/win/process_snapshot_win.h b/snapshot/win/process_snapshot_win.h
index 6cb4976d1ba1e5e5e22dedf68d02d1e6d0d6e7b4..5c0b1b3554c1c323aa0d7c4d4adc3f9e0d972e5e 100644
--- a/snapshot/win/process_snapshot_win.h
+++ b/snapshot/win/process_snapshot_win.h
@@ -52,10 +52,14 @@ class ProcessSnapshotWin final : public ProcessSnapshot {
//! \brief Initializes the object.
//!
//! \param[in] process The handle to create a snapshot from.
+ //! \param[in] suspension_state Whether \a process has been suspended by the
+ //! caller.
//!
//! \return `true` if the snapshot could be created, `false` otherwise with
//! an appropriate message logged.
- bool Initialize(HANDLE process);
+ //!
+ //! \sa ScopedProcessSuspend
+ bool Initialize(HANDLE process, ProcessSuspensionState suspension_state);
//! \brief Initializes the object's exception.
//!
« no previous file with comments | « snapshot/win/process_reader_win_test.cc ('k') | snapshot/win/process_snapshot_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698