Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Side by Side Diff: snapshot/win/process_snapshot_win.h

Issue 1326443007: win: Fix incorrect thread suspend count due to ScopedProcessSuspend (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: assert some threads captured Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « snapshot/win/process_reader_win_test.cc ('k') | snapshot/win/process_snapshot_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Crashpad Authors. All rights reserved. 1 // Copyright 2015 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 //! \brief A ProcessSnapshot of a running (or crashed) process running on a 45 //! \brief A ProcessSnapshot of a running (or crashed) process running on a
46 //! Windows system. 46 //! Windows system.
47 class ProcessSnapshotWin final : public ProcessSnapshot { 47 class ProcessSnapshotWin final : public ProcessSnapshot {
48 public: 48 public:
49 ProcessSnapshotWin(); 49 ProcessSnapshotWin();
50 ~ProcessSnapshotWin() override; 50 ~ProcessSnapshotWin() override;
51 51
52 //! \brief Initializes the object. 52 //! \brief Initializes the object.
53 //! 53 //!
54 //! \param[in] process The handle to create a snapshot from. 54 //! \param[in] process The handle to create a snapshot from.
55 //! \param[in] suspension_state Whether \a process has been suspended by the
56 //! caller.
55 //! 57 //!
56 //! \return `true` if the snapshot could be created, `false` otherwise with 58 //! \return `true` if the snapshot could be created, `false` otherwise with
57 //! an appropriate message logged. 59 //! an appropriate message logged.
58 bool Initialize(HANDLE process); 60 //!
61 //! \sa ScopedProcessSuspend
62 bool Initialize(HANDLE process, ProcessSuspensionState suspension_state);
59 63
60 //! \brief Initializes the object's exception. 64 //! \brief Initializes the object's exception.
61 //! 65 //!
62 //! This populates the data to be returned by Exception(). 66 //! This populates the data to be returned by Exception().
63 //! 67 //!
64 //! This method must not be called until after a successful call to 68 //! This method must not be called until after a successful call to
65 //! Initialize(). 69 //! Initialize().
66 //! 70 //!
67 //! \param[in] exception_information_address The address in the client 71 //! \param[in] exception_information_address The address in the client
68 //! process's address space of an ExceptionInformation structure. 72 //! process's address space of an ExceptionInformation structure.
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 std::map<std::string, std::string> annotations_simple_map_; 141 std::map<std::string, std::string> annotations_simple_map_;
138 timeval snapshot_time_; 142 timeval snapshot_time_;
139 InitializationStateDcheck initialized_; 143 InitializationStateDcheck initialized_;
140 144
141 DISALLOW_COPY_AND_ASSIGN(ProcessSnapshotWin); 145 DISALLOW_COPY_AND_ASSIGN(ProcessSnapshotWin);
142 }; 146 };
143 147
144 } // namespace crashpad 148 } // namespace crashpad
145 149
146 #endif // CRASHPAD_SNAPSHOT_WIN_PROCESS_SNAPSHOT_WIN_H_ 150 #endif // CRASHPAD_SNAPSHOT_WIN_PROCESS_SNAPSHOT_WIN_H_
OLDNEW
« no previous file with comments | « snapshot/win/process_reader_win_test.cc ('k') | snapshot/win/process_snapshot_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698