Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: util/win/exception_handler_server.cc

Issue 1326443007: win: Fix incorrect thread suspend count due to ScopedProcessSuspend (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: pass in state Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« snapshot/win/process_reader_win.cc ('K') | « tools/generate_dump.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/win/exception_handler_server.cc
diff --git a/util/win/exception_handler_server.cc b/util/win/exception_handler_server.cc
index 547087e04be714bcf41feda9c791c1bb489dbdfe..c736b016f30a65f601b1d601cf4266ab96a060ac 100644
--- a/util/win/exception_handler_server.cc
+++ b/util/win/exception_handler_server.cc
@@ -27,6 +27,7 @@
#include "util/misc/tri_state.h"
#include "util/misc/uuid.h"
#include "util/win/registration_protocol_win.h"
+#include "util/win/scoped_process_suspend.h"
namespace crashpad {
@@ -408,6 +409,8 @@ void __stdcall ExceptionHandlerServer::OnDumpEvent(void* ctx, BOOLEAN) {
internal::ClientData* client = reinterpret_cast<internal::ClientData*>(ctx);
base::AutoLock lock(*client->lock());
+ ScopedProcessSuspend suspend(client->process());
Mark Mentovai 2015/09/09 18:57:27 I think this worked better in CrashReportException
scottmg 2015/09/09 19:13:25 OK, done.
+
// Capture the exception.
unsigned int exit_code = client->delegate()->ExceptionHandlerServerException(
client->process(), client->exception_information_address());
« snapshot/win/process_reader_win.cc ('K') | « tools/generate_dump.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698