win: Fix incorrect thread suspend count due to ScopedProcessSuspend

util/win/exception_handler_server.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "util/win/exception_handler_server.h"
 
 #include <string.h>
 
 #include "base/logging.h"
 #include "base/rand_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "minidump/minidump_file_writer.h"
 #include "snapshot/crashpad_info_client_options.h"
 #include "snapshot/win/process_snapshot_win.h"
 #include "util/file/file_writer.h"
 #include "util/misc/tri_state.h"
 #include "util/misc/uuid.h"
 #include "util/win/registration_protocol_win.h"
+#include "util/win/scoped_process_suspend.h"
 
 namespace crashpad {
 
 namespace {
 
 decltype(GetNamedPipeClientProcessId)* GetNamedPipeClientProcessIdFunction() {
   static decltype(GetNamedPipeClientProcessId)* func =
       reinterpret_cast<decltype(GetNamedPipeClientProcessId)*>(GetProcAddress(
           GetModuleHandle(L"kernel32.dll"), "GetNamedPipeClientProcessId"));
   return func;
@@ skipping 361 matching lines @@
 
   return 0;
 }
 
 // static
 void __stdcall ExceptionHandlerServer::OnDumpEvent(void* ctx, BOOLEAN) {
   // This function is executed on the thread pool.
   internal::ClientData* client = reinterpret_cast<internal::ClientData*>(ctx);
   base::AutoLock lock(*client->lock());
 
+  ScopedProcessSuspend suspend(client->process());

[Mark Mentovai, 2015/09/09 18:57:27]

I think this worked better in CrashReportExceptionHandler. I don’t think it
should be up to the base to decide whether suspension is appropriate or not.
That’s a decision for the delegate.

[scottmg, 2015/09/09 19:13:25]

OK, done.

+
   // Capture the exception.
   unsigned int exit_code = client->delegate()->ExceptionHandlerServerException(
       client->process(), client->exception_information_address());
 
   TerminateProcess(client->process(), exit_code);
 }
 
 // static
 void __stdcall ExceptionHandlerServer::OnProcessEnd(void* ctx, BOOLEAN) {
   // This function is executed on the thread pool.
   internal::ClientData* client = reinterpret_cast<internal::ClientData*>(ctx);
   base::AutoLock lock(*client->lock());
 
   // Post back to the main thread to have it delete this client record.
   PostQueuedCompletionStatus(client->port(), 0, ULONG_PTR(client), nullptr);
 }
 
 }  // namespace crashpad