Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 1326273003: Add logging to profile downloader to diagnose Android FR issue. (Closed)

Created:
5 years, 3 months ago by anthonyvd
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add logging to profile downloader to diagnose Android FR issue. This is a very temporary fix that will be reverted in a few days when the additional information has been used to pinpoint the bug. BUG=500854, 530453 Committed: https://crrev.com/55e6026b5e2016626cf3abf126e55e421e0aa2b2 Cr-Commit-Position: refs/heads/master@{#347932}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M chrome/browser/profiles/profile_downloader.cc View 3 chunks +11 lines, -6 lines 0 comments Download
M components/signin/core/browser/account_fetcher_service.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
anthonyvd
Hi Roger can you please take a look at this CL that adds logging to ...
5 years, 3 months ago (2015-09-08 16:17:51 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
5 years, 3 months ago (2015-09-09 14:13:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326273003/1
5 years, 3 months ago (2015-09-09 14:41:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 15:12:30 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/55e6026b5e2016626cf3abf126e55e421e0aa2b2 Cr-Commit-Position: refs/heads/master@{#347932}
5 years, 3 months ago (2015-09-09 15:13:03 UTC) #7
Thiemo Nagel
5 years, 3 months ago (2015-09-14 09:02:23 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1339783003/ by tnagel@chromium.org.

The reason for reverting is: Reverting because of reproducible crash, cf.
https://crbug.com/530453..

Powered by Google App Engine
This is Rietveld 408576698