Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2423)

Unified Diff: chrome/browser/profiles/profile_downloader.cc

Issue 1326273003: Add logging to profile downloader to diagnose Android FR issue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/signin/core/browser/account_fetcher_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profiles/profile_downloader.cc
diff --git a/chrome/browser/profiles/profile_downloader.cc b/chrome/browser/profiles/profile_downloader.cc
index f6364fd7e0bc04a20439ca93bd59d75400f60e7f..40d6cb8ab1f674c39a46fb068a502e38cdbf60d1 100644
--- a/chrome/browser/profiles/profile_downloader.cc
+++ b/chrome/browser/profiles/profile_downloader.cc
@@ -223,15 +223,15 @@ void ProfileDownloader::StartFetchingImage() {
VLOG(1) << "Fetching user entry with token: " << auth_token_;
account_info_ = account_tracker_service_->GetAccountInfo(account_id_);
- if (delegate_->IsPreSignin()) {
- AccountFetcherServiceFactory::GetForProfile(delegate_->GetBrowserProfile())
- ->FetchUserInfoBeforeSignin(account_id_);
- }
-
if (account_info_.IsValid())
FetchImageData();
else
waiting_for_account_info_ = true;
+
+ if (delegate_->IsPreSignin()) {
+ AccountFetcherServiceFactory::GetForProfile(delegate_->GetBrowserProfile())
+ ->FetchUserInfoBeforeSignin(account_id_);
+ }
}
void ProfileDownloader::StartFetchingOAuth2AccessToken() {
@@ -302,6 +302,12 @@ void ProfileDownloader::OnURLFetchComplete(const net::URLFetcher* source) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
std::string data;
source->GetResponseAsString(&data);
+ LOG(WARNING) << "Profile image URL fetch for image at "
+ << source->GetURL().possibly_invalid_spec()
+ << " completed with status: "
+ << source->GetStatus().status()
+ << " and response code: " << source->GetResponseCode()
+ << " data size: " << data.size();
bool network_error =
source->GetStatus().status() != net::URLRequestStatus::SUCCESS;
if (network_error || source->GetResponseCode() != 200) {
@@ -316,7 +322,6 @@ void ProfileDownloader::OnURLFetchComplete(const net::URLFetcher* source) {
ProfileDownloaderDelegate::SERVICE_ERROR);
} else {
profile_image_fetcher_.reset();
- VLOG(1) << "Decoding the image...";
ImageDecoder::Start(this, data);
}
}
« no previous file with comments | « no previous file | components/signin/core/browser/account_fetcher_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698