Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 13262: Make the spellcheck-context-menu generation code more robust/future-proof. ... (Closed)

Created:
12 years ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
sidchat (Google)
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make the spellcheck-context-menu generation code more robust/future-proof (fil and fil-PH will match each other). Currently, en-AU, de-CH, fr-CA do not match any spellcheck language. With this change, they will match en-US, de-DE, fr-FR, respectively unless there's an exact (more specific) match. Matching en-{AU,NZ,ZA} with en-US is not ideal. BUG=5251 TEST=Add 'fr-CA' (but NOT fr or fr-FR) to the accept-language list and see if 'fr-FR' comes up in the list of spell-check languages in the context menu of a textarea. Add 'de' (but not de-DE) to a-l list and see if 'de-DE' comes up in the list of spell-check languages in the context menu. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6562

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M chrome/browser/spellchecker.cc View 1 1 chunk +17 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jungshik at Google
12 years ago (2008-12-08 23:07:57 UTC) #1
sidchat (Google)
12 years ago (2008-12-08 23:21:16 UTC) #2
LGTM

On 2008/12/08 23:07:57, Jungshik Shin wrote:
>

Powered by Google App Engine
This is Rietveld 408576698