Make the spellcheck-context-menu generation code more robust/future-proof. ...

chrome/browser/spellchecker.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <io.h>
 
 #include "chrome/browser/spellchecker.h"
 #include "base/basictypes.h"
 #include "base/file_util.h"
 #include "base/histogram.h"
@@ skipping 73 matching lines @@
 
 std::wstring SpellChecker::GetCorrespondingSpellCheckLanguage(
     const std::wstring& language) {
   // Look for exact match in the Spell Check language list.
   for (int i = 0; i < arraysize(g_supported_spellchecker_languages); ++i) {
     std::wstring spellcheck_language(g_supported_spellchecker_languages[i]);
     if (spellcheck_language == language)
       return language;
   }
 
-  // Find match for the language. For example, for "hi", the corresponding
-  // Spell Check language is "hi-IN". The input language has to be 2 letter.
-  if (language.length() == 2) {
-    for (int i = 0; i < arraysize(g_supported_spellchecker_languages); ++i) {
-      std::wstring spellcheck_language(g_supported_spellchecker_languages[i]);
-      std::wstring spellcheck_country(spellcheck_language.substr(0, 2));
-      if (spellcheck_country == language)
-        return spellcheck_language;
-    } 
-  }
+  // Look for a match by comparing only language parts. All the 'en-RR'
+  // except for 'en-GB' exactly matched in the above loop, will match 
+  // 'en-US'. This is not ideal because 'en-AU', 'en-ZA', 'en-NZ' had 
+  // better be matched with 'en-GB'. This does not handle cases like
+  // 'az-Latn-AZ' vs 'az-Arab-AZ', either, but we don't use 3-part
+  // locale ids with a script code in the middle, yet.
+  // TODO(jungshik): Add a better fallback.
+  std::wstring::size_type hyphen_pos = language.find(L'-');
+  std::wstring language_part(language, 0, hyphen_pos);
+  for (int i = 0; i < arraysize(g_supported_spellchecker_languages); ++i) {
+    std::wstring spellchecker_language_name 
+      = g_supported_spellchecker_languages[i];
+    std::wstring::size_type hyphen_pos = spellchecker_language_name.find(L'-');
+    std::wstring spellcheck_language(spellchecker_language_name, 0, hyphen_pos);
+    if (spellcheck_language == language_part)
+      return spellchecker_language_name;
+  } 
 
   // No match found - return blank.
   return std::wstring();
 }
 
 int SpellChecker::GetSpellCheckLanguagesToDisplayInContextMenu(
     Profile* profile, std::vector<std::wstring>* display_language_list) {
   std::vector<std::wstring> language_list;
   StringPrefMember accept_languages;
   StringPrefMember dictionary_language;
@@ skipping 531 matching lines @@
   // Now add the word to the custom dictionary file in the file loop.
   if (file_loop_) {
     file_loop_->PostTask(FROM_HERE, new AddWordToCustomDictionaryTask(
         custom_dictionary_file_name_, word));
   } else {  // just run it in this thread.
     Task* write_word_task = new AddWordToCustomDictionaryTask(
         custom_dictionary_file_name_, word);
     write_word_task->Run();
   }
 }