Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1326153002: Add PIXEL_FORMAT_MT21. (Closed)

Created:
5 years, 3 months ago by wuchengli
Modified:
5 years, 3 months ago
CC:
chromium-reviews, Daniel Kurtz, scott chuang, miu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add PIXEL_FORMAT_MT21. MT21 is a MediaTek proprietary format. MT21 is similar to NV21 except the memory layout and pixel layout (swizzles). YUV 4:2:0. 2x2 VU samples. 12 bits per pixel. Each image contains two buffers, one for Y plane and one for interleaved VU plane. Two planes can be non-contiguous in memory. Suppose image dimension is (width, height) Plane[0]: Y plane Start address alignment = 4K bytes Offset from Buffer[0] start address = 0 Row pitch = ((width+15)/16) * 16 Plane size = Row pitch * (((height+31)/32)*32) Plane[1]: VU plane Start address alignment = 4K bytes Offset from Buffer[1] start address = 0 Row pitch = ((width+15)/16) * 16 Plane size = Row pitch * (((height+31)/32)*32)/2 BUG=chrome-os-partner:44784 TESTS=Play video and run apprtc loopback. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/d9d4b9bb1bcb007db751a7473e00167ea9ffeb2f Cr-Commit-Position: refs/heads/master@{#348575}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : add MT21 to more files #

Patch Set 4 : address piman's comment #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M cc/resources/video_resource_updater.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_device_client_unittest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M media/base/video_frame.cc View 1 2 3 4 4 chunks +5 lines, -2 lines 0 comments Download
M media/base/video_types.h View 1 2 3 1 chunk +10 lines, -1 line 0 comments Download
M media/base/video_types.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M media/blink/skcanvas_video_renderer.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M media/blink/video_frame_compositor.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/interfaces/media_types.mojom View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M media/mojo/services/media_type_converters.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M media/video/gpu_memory_buffer_video_frame_pool.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 25 (9 generated)
wuchengli
Pawel. PTAL.
5 years, 3 months ago (2015-09-09 09:13:58 UTC) #2
wuchengli
piman@ Owner review for cc/ mcasas@ Owner review for content/browser/renderer_host/media dalecurtis@ Owner review for media/ ...
5 years, 3 months ago (2015-09-10 14:00:44 UTC) #4
Alexei Svitkine (slow)
histograms.xml lgtm
5 years, 3 months ago (2015-09-10 14:48:33 UTC) #5
DaleCurtis
media/ lgtm
5 years, 3 months ago (2015-09-10 15:59:49 UTC) #6
piman
LGTM. Could you add the description of the layout that you have in the CL ...
5 years, 3 months ago (2015-09-10 18:31:42 UTC) #7
wuchengli
On 2015/09/10 18:31:42, piman (slow to review) wrote: > LGTM. Could you add the description ...
5 years, 3 months ago (2015-09-11 13:30:38 UTC) #8
wuchengli
mcasas@ owner review for content/browser/renderer_host/media/video_capture_device_client_unittest.cc. Thanks.
5 years, 3 months ago (2015-09-11 13:30:56 UTC) #9
mcasas
lgtm
5 years, 3 months ago (2015-09-12 00:42:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326153002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326153002/60001
5 years, 3 months ago (2015-09-12 02:48:23 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/68455) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-09-12 02:50:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326153002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326153002/80001
5 years, 3 months ago (2015-09-12 03:47:00 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/69021)
5 years, 3 months ago (2015-09-12 09:49:28 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326153002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326153002/80001
5 years, 3 months ago (2015-09-14 03:53:40 UTC) #22
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 3 months ago (2015-09-14 06:31:49 UTC) #23
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/d9d4b9bb1bcb007db751a7473e00167ea9ffeb2f Cr-Commit-Position: refs/heads/master@{#348575}
5 years, 3 months ago (2015-09-14 06:32:26 UTC) #24
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:30:23 UTC) #25
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/d9d4b9bb1bcb007db751a7473e00167ea9ffeb2f
Cr-Commit-Position: refs/heads/master@{#348575}

Powered by Google App Engine
This is Rietveld 408576698