Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: pkg/unittest/lib/unittest.dart

Issue 13261006: pkg/unittest: cleanup to logMessage (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: nit Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/unittest/lib/src/config.dart ('K') | « pkg/unittest/lib/src/config.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/lib/unittest.dart
diff --git a/pkg/unittest/lib/unittest.dart b/pkg/unittest/lib/unittest.dart
index a0f5ffc3e41f8ee66f41e12c881518197ec52713..409aa81195b7995b8c249f5194bd65976f5ee294 100644
--- a/pkg/unittest/lib/unittest.dart
+++ b/pkg/unittest/lib/unittest.dart
@@ -185,7 +185,12 @@ void set unittestConfiguration(Configuration value) {
}
}
-void logMessage(String message) => _config.logMessage(message);
+/**
kevmoo-old 2013/03/29 02:19:25 Call the corresponding logTestCaseMessage on the c
+ * Can be called by tests to log status. Tests should use this
+ * instead of [print].
+ */
+void logMessage(String message) =>
+ _config.logTestCaseMessage(currentTestCase, message);
/**
* Description text of the current test group. If multiple groups are nested,
@@ -785,7 +790,7 @@ void _completeTests() {
case ERROR: errors++; break;
}
}
- _config.onSummary(passed, failed, errors, _testCases, _uncaughtErrorMessage);
+ _config.onSummary(passed, failed, errors, testCases, _uncaughtErrorMessage);
kevmoo-old 2013/03/29 02:19:25 Tiny nit. Pass onSummary the immutable view of tes
_config.onDone(passed > 0 && failed == 0 && errors == 0 &&
_uncaughtErrorMessage == null);
_initialized = false;
« pkg/unittest/lib/src/config.dart ('K') | « pkg/unittest/lib/src/config.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698