pkg/unittest: cleanup to logMessage

pkg/unittest/lib/unittest.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * A library for writing dart unit tests.
  *
  * To import this library, install the
  * [unittest package](http://pub.dartlang.org/packages/unittest) via the pub
  * package manager. See the [Getting Started](http://pub.dartlang.org/doc)
@@ skipping 167 matching lines @@
  */
 void set unittestConfiguration(Configuration value) {
   if(!identical(_config, value)) {
     if(_config != null) {
       throw new StateError('unittestConfiguration has already been set');
     }
     _config = value;
   }
 }
 
-void logMessage(String message) => _config.logMessage(message);
+/**

[kevmoo-old, 2013/03/29 02:19:25]

Call the corresponding logTestCaseMessage on the config.

Behavior remains the same with currentTestCase potentially being null

+ * Can be called by tests to log status. Tests should use this
+ * instead of [print].
+ */
+void logMessage(String message) =>
+    _config.logTestCaseMessage(currentTestCase, message);
 
 /**
  * Description text of the current test group. If multiple groups are nested,
  * this will contain all of their text concatenated.
  */
 String _currentGroup = '';
 
 /** Separator used between group names and test names. */
 String groupSep = ' ';
 
@@ skipping 579 matching lines @@
   int failed = 0;
   int errors = 0;
 
   for (TestCase t in _testCases) {
     switch (t.result) {
       case PASS:  passed++; break;
       case FAIL:  failed++; break;
       case ERROR: errors++; break;
     }
   }
-  _config.onSummary(passed, failed, errors, _testCases, _uncaughtErrorMessage);
+  _config.onSummary(passed, failed, errors, testCases, _uncaughtErrorMessage);

[kevmoo-old, 2013/03/29 02:19:25]

Tiny nit. Pass onSummary the immutable view of testCases.

   _config.onDone(passed > 0 && failed == 0 && errors == 0 &&
       _uncaughtErrorMessage == null);
   _initialized = false;
 }
 
 String _fullSpec(String spec) {
   if (spec == null) return '$_currentGroup';
   return _currentGroup != '' ? '$_currentGroup$groupSep$spec' : spec;
 }
 
@@ skipping 48 matching lines @@
 }
 
 /** Enable a test by ID. */
 void enableTest(int testId) => _setTestEnabledState(testId, true);
 
 /** Disable a test by ID. */
 void disableTest(int testId) => _setTestEnabledState(testId, false);
 
 /** Signature for a test function. */
 typedef dynamic TestFunction();