Issue 1326013002: Refactor Lo and Hi out of Variable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1326013002: Refactor Lo and Hi out of Variable. (Closed)

Created:
5 years, 3 months ago by ascull

Modified:
5 years, 3 months ago

Reviewers:
jvoung (off chromium), Jim Stichnoth, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+168 lines, -183 lines)			Patch
M	src/IceCfg.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/IceCfg.cpp	View	1	2 chunks	+15 lines, -0 lines	0 comments	Download
M	src/IceInst.cpp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/IceOperand.h	View	1	6 chunks	+72 lines, -23 lines	0 comments	Download
M	src/IceTargetLowering.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/IceTargetLoweringARM32.h	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/IceTargetLoweringARM32.cpp	View	1	7 chunks	+27 lines, -63 lines	0 comments	Download
M	src/IceTargetLoweringMIPS32.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/IceTargetLoweringX8632.cpp	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	src/IceTargetLoweringX86Base.h	View	1	2 chunks	+4 lines, -15 lines	0 comments	Download
M	src/IceTargetLoweringX86BaseImpl.h	View	1	6 chunks	+32 lines, -75 lines	0 comments	Download

Total messages: 5 (1 generated)

ascull

Advantages: - makes 64 bit lowering code a bit cleaner/more obvious - Variable is smaller ...

5 years, 3 months ago (2015-09-17 20:11:20 UTC) #1

ascull

5 years, 3 months ago (2015-09-18 00:10:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
6d47bcdcf16ce8eddc737d4f26baad9653604048 (presubmit successful).