Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1326013002: Refactor Lo and Hi out of Variable. (Closed)

Created:
5 years, 3 months ago by ascull
Modified:
5 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Refactor Hi and Lo out of Variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -183 lines) Patch
M src/IceCfg.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/IceCfg.cpp View 1 2 chunks +15 lines, -0 lines 0 comments Download
M src/IceInst.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/IceOperand.h View 1 6 chunks +72 lines, -23 lines 0 comments Download
M src/IceTargetLowering.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M src/IceTargetLoweringARM32.cpp View 1 7 chunks +27 lines, -63 lines 0 comments Download
M src/IceTargetLoweringMIPS32.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download
M src/IceTargetLoweringX86Base.h View 1 2 chunks +4 lines, -15 lines 0 comments Download
M src/IceTargetLoweringX86BaseImpl.h View 1 6 chunks +32 lines, -75 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ascull
Advantages: - makes 64 bit lowering code a bit cleaner/more obvious - Variable is smaller ...
5 years, 3 months ago (2015-09-17 20:11:20 UTC) #1
ascull
5 years, 3 months ago (2015-09-17 20:11:44 UTC) #3
Jim Stichnoth
lgtm
5 years, 3 months ago (2015-09-17 20:46:14 UTC) #4
ascull
5 years, 3 months ago (2015-09-18 00:10:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6d47bcdcf16ce8eddc737d4f26baad9653604048 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698