Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 1325833005: Make presubmit.py rules differential. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make presubmit.py rules differential. This turns the absolute list of linter rules within the presubmit.py wrapper into a list relative to the default of the cpplint.py script. This has the advantage that new rules are picked up when the script is updated and that allowed violations are visible from the list. R=machenbach@chromium.org Committed: https://crrev.com/77e40bc5f3227f8bdeba9de6e7fa363ec5ed4f8f Cr-Commit-Position: refs/heads/master@{#30513}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -57 lines) Patch
M tools/presubmit.py View 2 chunks +27 lines, -57 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (1 generated)
Michael Starzinger
5 years, 3 months ago (2015-09-01 13:32:03 UTC) #1
Michael Achenbach
LGTM - please clobber the lint cache and run this locally to ensure we're not ...
5 years, 3 months ago (2015-09-01 13:40:27 UTC) #2
Michael Starzinger
Thanks! Yep did so, ran "rm .cpplint-cache; ./tools/presubmit.py" locally.
5 years, 3 months ago (2015-09-01 13:50:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325833005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325833005/1
5 years, 3 months ago (2015-09-01 13:57:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 14:28:27 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 14:28:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77e40bc5f3227f8bdeba9de6e7fa363ec5ed4f8f
Cr-Commit-Position: refs/heads/master@{#30513}

Powered by Google App Engine
This is Rietveld 408576698