Issue 1302413007: [presubmit] Fix runtime/indentation_namespace linter violations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1302413007: [presubmit] Fix runtime/indentation_namespace linter violations. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger

Modified:
5 years, 3 months ago

Reviewers:
Michael Achenbach

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://chromium.googlesource.com/v8/v8.git@local_fix-presubmit-rules

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[presubmit] Fix runtime/indentation_namespace linter violations. R=machenbach@chromium.org Committed: https://crrev.com/093f7260e9260b5ea0fc8b78b6b7c68cf37c5112 Cr-Commit-Position: refs/heads/master@{#30514}

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -4 lines)			Patch
M	include/v8.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/globals.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/presubmit.py	View	1 chunk	+0 lines, -1 line	0 comments	Download

Depends on Patchset:

Issue 1325833005 Patch 1

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302413007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302413007/1

5 years, 3 months ago (2015-09-01 14:54:55 UTC) #4

commit-bot: I haz the power

5 years, 3 months ago (2015-09-01 15:20:17 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/093f7260e9260b5ea0fc8b78b6b7c68cf37c5112
Cr-Commit-Position: refs/heads/master@{#30514}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages