Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Unified Diff: base/profiler/stack_sampling_profiler.h

Issue 1325653003: Type change in StackSamplingProfiler from void* to uintptr_t. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@UMA2_refactor
Patch Set: Nits and compiles. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/profiler/stack_sampling_profiler.h
diff --git a/base/profiler/stack_sampling_profiler.h b/base/profiler/stack_sampling_profiler.h
index 5a6c3d0514d00a337d462f06e79c0e89ced5a249..f27609e12dbedfdb4c4365b8efa5fa6b67085f85 100644
--- a/base/profiler/stack_sampling_profiler.h
+++ b/base/profiler/stack_sampling_profiler.h
@@ -64,12 +64,13 @@ class BASE_EXPORT StackSamplingProfiler {
// Module represents the module (DLL or exe) corresponding to a stack frame.
struct BASE_EXPORT Module {
Module();
- Module(const void* base_address, const std::string& id,
+ Module(uintptr_t base_address,
+ const std::string& id,
const FilePath& filename);
~Module();
// Points to the base address of the module.
- const void* base_address;
+ uintptr_t base_address;
// An opaque binary string that uniquely identifies a particular program
// version with high probability. This is parsed from headers of the loaded
@@ -89,11 +90,14 @@ class BASE_EXPORT StackSamplingProfiler {
// Identifies an unknown module.
static const size_t kUnknownModuleIndex = static_cast<size_t>(-1);
- Frame(const void* instruction_pointer, size_t module_index);
+ Frame(uintptr_t instruction_pointer, size_t module_index);
~Frame();
+ // Default constructor to satisfy IPC macros. Do not use explicitly.
+ Frame();
+
// The sampled instruction pointer within the function.
- const void* instruction_pointer;
+ uintptr_t instruction_pointer;
// Index of the module in CallStackProfile::modules. We don't represent
// module state directly here to save space.

Powered by Google App Engine
This is Rietveld 408576698