Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2996)

Unified Diff: base/profiler/stack_sampling_profiler.cc

Issue 1325653003: Type change in StackSamplingProfiler from void* to uintptr_t. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@UMA2_refactor
Patch Set: Nits and compiles. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/profiler/stack_sampling_profiler.h ('k') | base/profiler/stack_sampling_profiler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/profiler/stack_sampling_profiler.cc
diff --git a/base/profiler/stack_sampling_profiler.cc b/base/profiler/stack_sampling_profiler.cc
index 00a79b55bd7fd465f423fa3202bb48661d26e96a..7e4f65a07b2ce784a75f6a9a3c57be5e22540610 100644
--- a/base/profiler/stack_sampling_profiler.cc
+++ b/base/profiler/stack_sampling_profiler.cc
@@ -83,8 +83,8 @@ void AsyncRunner::RunCallbackAndDeleteInstance(
// StackSamplingProfiler::Module ----------------------------------------------
-StackSamplingProfiler::Module::Module() : base_address(nullptr) {}
-StackSamplingProfiler::Module::Module(const void* base_address,
+StackSamplingProfiler::Module::Module() : base_address(0u) {}
+StackSamplingProfiler::Module::Module(const uintptr_t base_address,
Alexei Svitkine (slow) 2015/09/09 17:15:54 Nit: Remove the const qualifier.
const std::string& id,
const FilePath& filename)
: base_address(base_address), id(id), filename(filename) {}
@@ -93,13 +93,14 @@ StackSamplingProfiler::Module::~Module() {}
// StackSamplingProfiler::Frame -----------------------------------------------
-StackSamplingProfiler::Frame::Frame(const void* instruction_pointer,
+StackSamplingProfiler::Frame::Frame(uintptr_t instruction_pointer,
size_t module_index)
- : instruction_pointer(instruction_pointer),
- module_index(module_index) {}
+ : instruction_pointer(instruction_pointer), module_index(module_index) {}
StackSamplingProfiler::Frame::~Frame() {}
+StackSamplingProfiler::Frame::Frame() {}
+
// StackSamplingProfiler::CallStackProfile ------------------------------------
StackSamplingProfiler::CallStackProfile::CallStackProfile() {}
« no previous file with comments | « base/profiler/stack_sampling_profiler.h ('k') | base/profiler/stack_sampling_profiler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698