Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1325643002: [heap] Fix recursive GCs caused by adjusting externally allocated memory (Closed)

Created:
5 years, 3 months ago by Michael Lippautz
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix recursive GCs caused by adjusting externally allocated memory R=mstarzinger@chromium.org BUG=chromium:526244 LOG=N Committed: https://crrev.com/1a8c38c50513f9af07ada479629a653e1cf36ff3 Cr-Commit-Position: refs/heads/master@{#30478}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M src/api.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +6 lines, -6 lines 1 comment Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325643002/1
5 years, 3 months ago (2015-08-31 13:49:41 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-31 14:14:47 UTC) #4
Michael Starzinger
LGTM. Thanks! https://codereview.chromium.org/1325643002/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/1325643002/diff/1/src/api.cc#newcode6876 src/api.cc:6876: DCHECK(heap->gc_state() == i::Heap::NOT_IN_GC); nit: DCHECK_EQ?
5 years, 3 months ago (2015-08-31 14:42:48 UTC) #5
Michael Lippautz
https://codereview.chromium.org/1325643002/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/1325643002/diff/1/src/api.cc#newcode6876 src/api.cc:6876: DCHECK(heap->gc_state() == i::Heap::NOT_IN_GC); On 2015/08/31 14:42:48, Michael Starzinger wrote: ...
5 years, 3 months ago (2015-08-31 15:00:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325643002/20001
5 years, 3 months ago (2015-08-31 15:01:02 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-31 15:36:31 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/1a8c38c50513f9af07ada479629a653e1cf36ff3 Cr-Commit-Position: refs/heads/master@{#30478}
5 years, 3 months ago (2015-08-31 15:36:44 UTC) #11
fedor.indutny
https://codereview.chromium.org/1325643002/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1325643002/diff/20001/src/heap/heap.cc#newcode1850 src/heap/heap.cc:1850: amount_of_external_allocated_memory_ += FreeDeadArrayBuffersHelper( This should be `-=`, right?
5 years, 3 months ago (2015-08-31 20:48:18 UTC) #13
Michael Lippautz
5 years, 3 months ago (2015-08-31 21:01:42 UTC) #14
Message was sent while issue was closed. 
On 2015/08/31 20:48:18, fedor.indutny wrote:
> https://codereview.chromium.org/1325643002/diff/20001/src/heap/heap.cc
> File src/heap/heap.cc (right):
> 
>
https://codereview.chromium.org/1325643002/diff/20001/src/heap/heap.cc#newcod...
> src/heap/heap.cc:1850: amount_of_external_allocated_memory_ +=
> FreeDeadArrayBuffersHelper(
> This should be `-=`, right?

Thanks a lot! Yeah, this one slipped through....

Powered by Google App Engine
This is Rietveld 408576698